Python server to test the actionable error feature.

Python server to test the actionable error feature.


BUG=94007, 70276
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102392

[lipalani1, 2011-08-31 19:55:12]

This is the python server I used for testing the feature. The protobuf in
reference is running through the commit bots now and you can look at it in the
following review url:
http://codereview.chromium.org/7621085/

[lipalani1, 2011-09-16 21:18:23]

Ping.
The test cases are coded up and pretty close to being LGTMed by monday. (They
depend on this server code and this needs to be checked in before that).

[lipalani1, 2011-09-21 22:35:33]

Ping.

[ncarter (slow), 2011-09-21 22:48:08]

http://codereview.chromium.org/7811026/diff/3001/net/tools/testserver/chromiu...
File net/tools/testserver/chromiumsync.py (right):

http://codereview.chromium.org/7811026/diff/3001/net/tools/testserver/chromiu...
net/tools/testserver/chromiumsync.py:106: 
Two blank lines here.

http://codereview.chromium.org/7811026/diff/7014/net/tools/testserver/chromiu...
File net/tools/testserver/chromiumsync.py (right):

http://codereview.chromium.org/7811026/diff/7014/net/tools/testserver/chromiu...
net/tools/testserver/chromiumsync.py:106: 
2 blank lines

http://codereview.chromium.org/7811026/diff/7014/net/tools/testserver/chromiu...
net/tools/testserver/chromiumsync.py:421: self.error =
sync_pb2.ClientToServerResponse.Error()
Three things:

[1] Eliminate self.send_error; just initialize (self.error = None) and use "if
self.error" instead of "if self.send_error".

[2] SyncDataModel should only have private data members.  
"self.account.send_error", while legal, is bad style.  Remember that the
intended divide is for SyncDataModel to contain account state, and for
TestServer to translate the account state into a protocol response. 

[3] Please pick a more descriptive name than 'error'.  Maybe 'scheduled_error'
or 'induced_error' or 'error_to_force' something like that; it just ought to
clarify that the error.

[lipalani1, 2011-09-22 20:14:35]

Please review.

http://codereview.chromium.org/7811026/diff/3001/net/tools/testserver/chromiu...
File net/tools/testserver/chromiumsync.py (right):

http://codereview.chromium.org/7811026/diff/3001/net/tools/testserver/chromiu...
net/tools/testserver/chromiumsync.py:106: 
On 2011/09/21 22:48:08, ncarter wrote:
> Two blank lines here.

Done.

[ncarter (slow), 2011-09-22 20:27:53]

LGTM with three nits

http://codereview.chromium.org/7811026/diff/24001/net/tools/testserver/chromi...
File net/tools/testserver/chromiumsync.py (right):

http://codereview.chromium.org/7811026/diff/24001/net/tools/testserver/chromi...
net/tools/testserver/chromiumsync.py:940:
sync_pb2.ClientToServerResponse.UNKNOWN:
"Make use of Python's implicit line joining inside parentheses, brackets and
braces."

So instead of escaping the newline this should be:

if (self.account.induced_error.error_type !=
    sync_pb2.ClientToServerResponse.UNKNOWN):

Reference:
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Line_length

http://codereview.chromium.org/7811026/diff/24001/net/tools/testserver/chromi...
net/tools/testserver/chromiumsync.py:981: error.error_description = \
Don't escape newlines.  It's very common to see expressions like:

error.error_description = (

http://codereview.chromium.org/7811026/diff/24001/net/tools/testserver/chromi...
net/tools/testserver/chromiumsync.py:1085: ### This is deprecated now. Would be
remvoved once test cases are removed.
"remvoved"