Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 7811016: Add support for shared library builds to tools/test-wrapper-gypbuild.py (Closed)

Created:
9 years, 3 months ago by Jakob Kummerow
Modified:
9 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Add support for shared library builds to tools/test-wrapper-gypbuild.py by setting LD_LIBRARY_PATH as required Committed: http://code.google.com/p/v8/source/detail?r=9085

Patch Set 1 #

Patch Set 2 : build cctest when component==shared_library #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M build/all.gyp View 1 1 chunk +1 line, -7 lines 0 comments Download
M test/cctest/cctest.gyp View 1 2 chunks +14 lines, -1 line 0 comments Download
M tools/test-wrapper-gypbuild.py View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAL.
9 years, 3 months ago (2011-08-31 09:39:42 UTC) #1
Jakob Kummerow
Made cctest build even when component=shared_library is set. PTAnotherL.
9 years, 3 months ago (2011-08-31 12:51:12 UTC) #2
Yang
9 years, 3 months ago (2011-08-31 13:50:13 UTC) #3
On 2011/08/31 12:51:12, Jakob wrote:
> Made cctest build even when component=shared_library is set. PTAnotherL.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698