src/v8natives.js - Issue 7811015: Change global const handling to silently ignore redeclarations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/v8natives.js

Issue 7811015: Change global const handling to silently ignore redeclarations (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: fix assertion failure Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/v8natives.js

diff --git a/src/v8natives.js b/src/v8natives.js

index 588bdb21bb0765d5297efca325bfdf1dcf1055bb..0d9cb74cbcb461944cd793ff140cd692a0dbd8ab 100644

--- a/src/v8natives.js

+++ b/src/v8natives.js

@@ -193,13 +193,14 @@ function GlobalEval(x) {

function SetUpGlobal() {

%CheckIsBootstrapping();

// ECMA 262 - 15.1.1.1.

- %SetProperty(global, "NaN", $NaN, DONT_ENUM | DONT_DELETE);

+ %SetProperty(global, "NaN", $NaN, DONT_ENUM | DONT_DELETE | READ_ONLY);

// ECMA-262 - 15.1.1.2.

- %SetProperty(global, "Infinity", 1/0, DONT_ENUM | DONT_DELETE);

+ %SetProperty(global, "Infinity", 1/0, DONT_ENUM | DONT_DELETE | READ_ONLY);

// ECMA-262 - 15.1.1.3.

- %SetProperty(global, "undefined", void 0, DONT_ENUM | DONT_DELETE);

+ %SetProperty(global, "undefined", void 0,

+ DONT_ENUM | DONT_DELETE | READ_ONLY);

// Set up non-enumerable function on the global object.

InstallFunctions(global, DONT_ENUM, $Array(

« no previous file with comments | « src/runtime.cc ('k') | test/cctest/test-decls.cc » ('j') | no next file with comments »