Change global const handling to silently ignore redeclarations

test/cctest/test-decls.cc

 // Copyright 2007-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 267 matching lines @@
   { PresentPropertyContext context;
     context.Check("function x() { }; x",
                   1,  // access
                   0,
                   0,
                   EXPECT_RESULT);
   }
 
   { PresentPropertyContext context;
     context.Check("const x; x",
+                  1,  // access
                   0,
-                  0,
-                  1,  // (re-)declaration
-                  EXPECT_EXCEPTION);  // x has already been declared!
+                  2,  // (re-)declaration + initialization
+                  EXPECT_EXCEPTION);  // x is not defined!
   }
 
   { PresentPropertyContext context;
     context.Check("const x = 0; x",
+                  1,  // access
                   0,
-                  0,
-                  1,  // (re-)declaration
-                  EXPECT_EXCEPTION);  // x has already been declared!
+                  2,  // (re-)declaration + initialization
+                  EXPECT_EXCEPTION);  // x is not defined!
   }
 }
 
 
 
 class AbsentPropertyContext: public DeclarationContext {
  protected:
   virtual v8::Handle<Integer> Query(Local<String> key) {
     return v8::Handle<Integer>();
   }
@@ skipping 112 matching lines @@
   { AppearingPropertyContext context;
     context.Check("function x() { }; x",
                   1,  // access
                   0,
                   0,
                   EXPECT_RESULT);
   }
 
   { AppearingPropertyContext context;
     context.Check("const x; x",
-                  0,
+                  1,  // access
                   1,  // declaration
                   2,  // declaration + initialization
-                  EXPECT_EXCEPTION);  // x has already been declared!
+                  EXPECT_RESULT, Undefined());
   }
 
   { AppearingPropertyContext context;
     context.Check("const x = 0; x",
-                  0,
+                  1,  // access
                   1,  // declaration
                   2,  // declaration + initialization
-                  EXPECT_EXCEPTION);  //  x has already been declared!
+                  EXPECT_RESULT, Undefined());
+                  // Result is undefined because declaration succeeded but
+                  // initialization to 0 failed (due to context behavior).
   }
 }
 
 
 
 class ReappearingPropertyContext: public DeclarationContext {
  public:
   enum State {
     DECLARE,
     DONT_DECLARE,
@@ skipping 37 matching lines @@
 
 
 TEST(Reappearing) {
   HandleScope scope;
 
   { ReappearingPropertyContext context;
     context.Check("const x; var x = 0",
                   0,
                   2,  // var declaration + const initialization
                   4,  // 2 x declaration + 2 x initialization
-                  EXPECT_EXCEPTION);  // x has already been declared!
+                  EXPECT_RESULT, Undefined());
   }
 }
 
 
 
 class ExistsInPrototypeContext: public DeclarationContext {
  protected:
   virtual v8::Handle<Integer> Query(Local<String> key) {
     // Let it seem that the property exists in the prototype object.
     return Integer::New(v8::None);
@@ skipping 72 matching lines @@
   HandleScope scope;
 
   { AbsentInPrototypeContext context;
     context.Check("if (false) { var x = 0; }; x",
                   0,
                   0,
                   1,  // declaration
                   EXPECT_RESULT, Undefined());
   }
 }