Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 7811014: When cross-compiling for ia32, do not build 'host' targets with -m32 (Closed)

Created:
9 years, 3 months ago by Ryan Sleevi
Modified:
9 years, 3 months ago
CC:
chromium-reviews, Peter Kasting
Visibility:
Public.

Description

When cross-compiling for ia32, do not build 'host' targets with -m32 BUG=94852 TEST=it (cross-)compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101014

Patch Set 1 #

Patch Set 2 : Line wrapping #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -62 lines) Patch
M build/common.gypi View 1 2 1 chunk +66 lines, -62 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Sleevi
Evan, I suspect you may be the best to chime in on the Linux cross-compiling ...
9 years, 3 months ago (2011-09-09 05:43:39 UTC) #1
Evan Martin
+cross-compile master
9 years, 3 months ago (2011-09-12 19:16:44 UTC) #2
piman
LGTM (assuming I read correctly, you're just moving the block inside of a toolset='target' condition ...
9 years, 3 months ago (2011-09-12 19:19:40 UTC) #3
commit-bot: I haz the power
Try job failure for 7811014-6001 (retry) (retry) on mac for step "compile" (clobber build). It's ...
9 years, 3 months ago (2011-09-13 07:29:54 UTC) #4
commit-bot: I haz the power
Try job failure for 7811014-6001 (retry) on mac for step "compile" (clobber build). It's a ...
9 years, 3 months ago (2011-09-13 08:51:43 UTC) #5
commit-bot: I haz the power
9 years, 3 months ago (2011-09-14 02:36:22 UTC) #6
Change committed as 101014

Powered by Google App Engine
This is Rietveld 408576698