Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: ui/base/text/text_elider.cc

Issue 7811006: Add full support for filesystem URLs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Test updates Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/text/text_elider.cc
diff --git a/ui/base/text/text_elider.cc b/ui/base/text/text_elider.cc
index 525cea0df61eb373507b91372f144dbf327cf419..08deea618d57ce0717a149455f0880571bfcc20b 100644
--- a/ui/base/text/text_elider.cc
+++ b/ui/base/text/text_elider.cc
@@ -171,8 +171,8 @@ string16 ElideUrl(const GURL& url,
if (available_pixel_width <= 0)
return url_string;
- // If non-standard or not file type, return plain eliding.
- if (!(url.SchemeIsFile() || url.IsStandard()))
sky 2012/02/15 16:17:28 nit: I prefer !foo && !foo. Easier to parse.
ericu 2012/02/15 22:32:10 Actually, you're commenting on the "before" code,
+ // If non-standard, return plain eliding.
+ if (!url.IsStandard())
return ElideText(url_string, font, available_pixel_width, ELIDE_AT_END);
// Now start eliding url_string to fit within available pixel width.

Powered by Google App Engine
This is Rietveld 408576698