chrome/common/extensions/url_pattern.cc - Issue 7811006: Add full support for filesystem URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/url_pattern.cc

Issue 7811006: Add full support for filesystem URLs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Better content_settings_pattern.cc changes. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/url_pattern.cc

diff --git a/chrome/common/extensions/url_pattern.cc b/chrome/common/extensions/url_pattern.cc

index c72f98cfea037dea5dc91f42eb2039577d86e76a..a7ee87d9b1e810a0f08f3d0d0a839d92dc28815e 100644

--- a/chrome/common/extensions/url_pattern.cc

+++ b/chrome/common/extensions/url_pattern.cc

@@ -153,6 +153,7 @@ URLPattern::ParseResult URLPattern::Parse(const std::string& pattern) {

if (!SetScheme(pattern.substr(0, scheme_end_pos)))

return PARSE_ERROR_INVALID_SCHEME;

+ // TODO(ericu): This will fail on filesystem URLs. What should it do?

bool standard_scheme = IsStandardScheme(scheme_);

if (standard_scheme != has_standard_scheme_separator)

return PARSE_ERROR_WRONG_SCHEME_SEPARATOR;