Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2797)

Unified Diff: chrome/common/extensions/url_pattern.h

Issue 7811006: Add full support for filesystem URLs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Style fixes, removed duplicate set of var Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/url_pattern.h
diff --git a/chrome/common/extensions/url_pattern.h b/chrome/common/extensions/url_pattern.h
index 6a83c017ce7c3b5a3dd2cd0348a16fd009352b14..ab0ab114adb401812f6eed1c80b55b53018cdc43 100644
--- a/chrome/common/extensions/url_pattern.h
+++ b/chrome/common/extensions/url_pattern.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef CHROME_COMMON_EXTENSIONS_URL_PATTERN_H_
@@ -119,6 +119,13 @@ class URLPattern {
bool match_all_urls() const { return match_all_urls_; }
void SetMatchAllURLs(bool val);
+ // Returns true if this pattern matches inner URLs of filesystem: URLs only.
+ // Returns false if this pattern matches only non-filesystem URLs.
+ bool partial_filesystem_support_hack() const {
+ return partial_filesystem_support_hack_;
+ }
+ void set_partial_filesystem_support_hack(bool val);
+
// Sets the scheme for pattern matches. This can be a single '*' if the
// pattern matches all valid schemes (as defined by the valid_schemes_
// property). Returns false on failure (if the scheme is not valid).
@@ -145,7 +152,9 @@ class URLPattern {
bool MatchesHost(const GURL& test) const;
// Returns true if |test| matches our path.
- bool MatchesPath(const std::string& test) const;
+ // Set filesystem_url to true if the path comes from a filesystem URL.
+ // See set_partial_filesystem_support_hack for behavior.
+ bool MatchesPath(const std::string& test, bool filesystem_url) const;
// Returns true if |port| matches our port.
bool MatchesPort(int port) const;
@@ -204,6 +213,11 @@ class URLPattern {
// True if this is a special-case "<all_urls>" pattern.
bool match_all_urls_;
+ // True if we're trying to match against the inner URL of a filesystem URL;
+ // this is a temporary hack so as not to break ChromeOS as we work on full
+ // support.
+ bool partial_filesystem_support_hack_;
+
// The scheme for the pattern.
std::string scheme_;

Powered by Google App Engine
This is Rietveld 408576698