Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: webkit/appcache/appcache_interfaces.cc

Issue 7811006: Add full support for filesystem URLs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed code review feedback. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/appcache/appcache_interfaces.cc
diff --git a/webkit/appcache/appcache_interfaces.cc b/webkit/appcache/appcache_interfaces.cc
index aac9766dce94274967fbd1c72377e64336df0d7c..975999588e0aea13acb11b72e79bbf92966f8bd5 100644
--- a/webkit/appcache/appcache_interfaces.cc
+++ b/webkit/appcache/appcache_interfaces.cc
@@ -63,11 +63,11 @@ bool IsSchemeSupported(const GURL& url) {
bool supported = url.SchemeIs(kHttpScheme) || url.SchemeIs(kHttpsScheme);
#ifndef NDEBUG
// TODO(michaeln): It would be really nice if this could optionally work for
- // file urls too to help web developers experiment and test their apps,
- // perhaps enabled via a cmd line flag or some other developer tool setting.
- // Unfortunately file scheme net::URLRequest don't produce the same signalling
- // (200 response codes, headers) as http URLRequests, so this doesn't work
- // just yet.
+ // file and filesystem urls too to help web developers experiment and test
+ // their apps, perhaps enabled via a cmd line flag or some other developer
+ // tool setting. Unfortunately file scheme net::URLRequests don't produce the
+ // same signalling (200 response codes, headers) as http URLRequests, so this
+ // doesn't work just yet.
// supported |= url.SchemeIsFile();
#endif
return supported;

Powered by Google App Engine
This is Rietveld 408576698