Add full support for filesystem URLs.

net/base/net_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/net_util.h"
 
 #include <algorithm>
 #include <iterator>
 #include <map>
 
@@ skipping 1880 matching lines @@
   string16 result = FormatUrlWithOffsets(url, languages, format_types,
       unescape_rules, new_parsed, prefix_end, &offsets);
   if (offset_for_adjustment)
     *offset_for_adjustment = offsets[0];
   return result;
 }
 
 bool CanStripTrailingSlash(const GURL& url) {
   // Omit the path only for standard, non-file URLs with nothing but "/" after
   // the hostname.
-  return url.IsStandard() && !url.SchemeIsFile() && !url.has_query() &&
-      !url.has_ref() && url.path() == "/";
+  return url.IsStandard() && !url.SchemeIsFile() &&
+      !url.SchemeIsFileSystem() && !url.has_query() && !url.has_ref()

[eroman, 2012/02/15 06:07:13]

I see, I think I understand a bit better what this change is about now:

You have introduced SchemeIsFileSystem() into GURL. However existing code may
not expect that, and may make assumption on stuff like what (url.IsStandard() &&
!url.SchemeIsFile())  entails.

Did you create this changelist by doing a search over Chrome codebase for all
occurrences of things like "IsStandard", "SchemeIsFile"?

Hmm that is tough. There could be other harder to find callers testing the
scheme string directly for instance.

[ericu, 2012/02/16 01:42:56]

Having looked through again, I found two files that are probably OK as they are,
but would be better with a bit of filesystem-specific code.  I'll either add
them to the patch next week [I'm out until Monday] or log bugs for later.

+      && url.path() == "/";
 }
 
 GURL SimplifyUrlForRequest(const GURL& url) {
   DCHECK(url.is_valid());
   GURL::Replacements replacements;
   replacements.ClearUsername();
   replacements.ClearPassword();
   replacements.ClearRef();
   return url.ReplaceComponents(replacements);
 }
@@ skipping 490 matching lines @@
 
 NetworkInterface::NetworkInterface(const std::string& name,
                                    const IPAddressNumber& address)
     : name(name), address(address) {
 }
 
 NetworkInterface::~NetworkInterface() {
 }
 
 }  // namespace net