Add full support for filesystem URLs.

webkit/fileapi/file_system_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/file_system_util.h"
 
 #include "build/build_config.h"
 
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/sys_string_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "googleurl/src/gurl.h"
 #include "net/base/escape.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebCString.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebSecurityOrigin.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebString.h"
 #include "webkit/fileapi/file_system_types.h"
 
 namespace fileapi {
 
-const char kPersistentDir[] = "/persistent/";
-const char kTemporaryDir[] = "/temporary/";
-const char kIsolatedDir[] = "/isolated/";
-const char kExternalDir[] = "/external/";
+const char kPersistentDir[] = "/persistent";
+const char kTemporaryDir[] = "/temporary";
+const char kIsolatedDir[] = "/isolated";
+const char kExternalDir[] = "/external";
 
 const char kPersistentName[] = "Persistent";
 const char kTemporaryName[] = "Temporary";
 const char kIsolatedName[] = "Isolated";
 const char kExternalName[] = "External";
 
 bool CrackFileSystemURL(const GURL& url, GURL* origin_url, FileSystemType* type,
                         FilePath* file_path) {
   GURL origin;
   FileSystemType file_system_type = kFileSystemTypeUnknown;
 
-  if (url.scheme() != "filesystem")
+  if (!url.is_valid() || !url.SchemeIsFileSystem())
     return false;
+  DCHECK(url.inner_url());
 
-  std::string temp = url.path();
-  // TODO(ericu): This should probably be done elsewhere after the stackable
-  // layers are properly in.  We're supposed to reject any paths that contain
-  // '..' segments, but the GURL constructor is helpfully resolving them for us.
-  // Make sure there aren't any before we call it.
-  size_t pos = temp.find("..");
-  for (; pos != std::string::npos; pos = temp.find("..", pos + 1)) {
-    if ((pos == 0 || temp[pos - 1] == '/') &&
-        (pos == temp.length() - 2 || temp[pos + 2] == '/'))
-      return false;
-  }
-
-  // bare_url will look something like:
-  //    http://example.com/temporary/dir/file.txt.
-  GURL bare_url(temp);
-
-  // The input URL was malformed, bail out early.
-  if (bare_url.path().empty())
-    return false;
-
-  origin = bare_url.GetOrigin();
-
-  // The input URL was malformed, bail out early.
-  if (origin.is_empty())
-    return false;
-
-  std::string path = net::UnescapeURLComponent(bare_url.path(),
-      net::UnescapeRule::SPACES | net::UnescapeRule::URL_SPECIAL_CHARS |
-      net::UnescapeRule::CONTROL_CHARS);
+  std::string inner_path = url.inner_url()->path();
 
   const struct {
     FileSystemType type;
     const char* dir;
   } kValidTypes[] = {
     { kFileSystemTypePersistent, kPersistentDir },
     { kFileSystemTypeTemporary, kTemporaryDir },
     { kFileSystemTypeIsolated, kIsolatedDir },
     { kFileSystemTypeExternal, kExternalDir },
   };
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(kValidTypes); ++i) {
-    if (StartsWithASCII(path, kValidTypes[i].dir, true)) {
+    if (StartsWithASCII(inner_path, kValidTypes[i].dir, true)) {
       file_system_type = kValidTypes[i].type;
-      path = path.substr(strlen(kValidTypes[i].dir));
       break;
     }
   }
 
   if (file_system_type == kFileSystemTypeUnknown)
     return false;
 
+  std::string path = net::UnescapeURLComponent(url.path(),
+      net::UnescapeRule::SPACES | net::UnescapeRule::URL_SPECIAL_CHARS |
+      net::UnescapeRule::CONTROL_CHARS);
+
   // Ensure the path is relative.
   while (!path.empty() && path[0] == '/')
     path.erase(0, 1);
 
+  FilePath converted_path = FilePath::FromUTF8Unsafe(path);
+
+  // All parent references should have been resolved in the renderer.
+  if (converted_path.ReferencesParent())
+    return false;
+
   if (origin_url)
-    *origin_url = origin;
+    *origin_url = url.GetOrigin();
   if (type)
     *type = file_system_type;
   if (file_path)
-    *file_path = FilePath::FromUTF8Unsafe(path).
-        NormalizePathSeparators().StripTrailingSeparators();
+    *file_path = converted_path.NormalizePathSeparators().
+        StripTrailingSeparators();
 
   return true;
 }
 
 //TODO(ericu): Consider removing support for '\', even on Windows, if possible.
 // There's a lot of test code that will need reworking, and we may have trouble
 // with FilePath elsewhere [e.g. DirName and other methods may also need
 // replacement].
 FilePath VirtualPath::BaseName(const FilePath& virtual_path) {
   FilePath::StringType path = virtual_path.value();
@@ skipping 30 matching lines @@
     base = BaseName(current);
     ret_val.push_back(base.value());
     current = current.DirName();
   }
 
   *components =
       std::vector<FilePath::StringType>(ret_val.rbegin(), ret_val.rend());
 }
 
 GURL GetFileSystemRootURI(const GURL& origin_url, FileSystemType type) {
-  std::string path("filesystem:");
-  path += origin_url.spec();
+  // origin_url is based on a security origin, so http://foo.com or file:///
+  // instead of the corresponding filesystem URL.
+  DCHECK(!origin_url.SchemeIsFileSystem());
+
+  std::string url = "filesystem:" + origin_url.GetWithEmptyPath().spec();
   switch (type) {
   case kFileSystemTypeTemporary:
-    path += (kTemporaryDir + 1);  // We don't want the leading slash.
-    return GURL(path);
+    url += (kTemporaryDir + 1);  // We don't want the leading slash.
+    return GURL(url + "/");
   case kFileSystemTypePersistent:
-    path += (kPersistentDir + 1);  // We don't want the leading slash.
-    return GURL(path);
+    url += (kPersistentDir + 1);  // We don't want the leading slash.
+    return GURL(url + "/");
   case kFileSystemTypeExternal:
-    path += (kExternalDir + 1);  // We don't want the leading slash.
-    return GURL(path);
+    url += (kExternalDir + 1);  // We don't want the leading slash.
+    return GURL(url + "/");
   case kFileSystemTypeIsolated:
     // Falling through; we won't call this for isolated filesystems.
   case kFileSystemTypeUnknown:
     NOTREACHED();
   }
   NOTREACHED();
   return GURL();
 }
 
 std::string GetFileSystemName(const GURL& origin_url, FileSystemType type) {
@@ skipping 73 matching lines @@
 
 FilePath StringToFilePath(const std::string& file_path_string) {
 #if defined(OS_WIN)
   return FilePath(UTF8ToUTF16(file_path_string));
 #elif defined(OS_POSIX)
   return FilePath(file_path_string);
 #endif
 }
 
 }  // namespace fileapi