Add full support for filesystem URLs.

chrome/common/extensions/extension.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/extension.h"
 
 #include <algorithm>
 
 #include "base/base64.h"
 #include "base/basictypes.h"
@@ skipping 817 matching lines @@
     return NULL;
   }
   for (size_t i = 0; i < list_value->GetSize(); ++i) {
     std::string filter;
     if (!list_value->GetString(i, &filter)) {
       *error = ExtensionErrorUtils::FormatErrorMessageUTF16(
           errors::kInvalidFileFilterValue, base::IntToString(i));
       return NULL;
     }
     StringToLowerASCII(&filter);
+    if (filter.substr(0, 10) != chrome::kFileSystemScheme ||

[Aaron Boodman, 2012/03/12 23:17:13]

Can you use StartsWith()?

[ericu, 2012/03/13 21:58:47]

Done.

+        filter[10] != ':') {
+      *error = ExtensionErrorUtils::FormatErrorMessageUTF16(
+          errors::kInvalidURLPatternError, filter);
+      return NULL;
+    }
+    filter.replace(11, 0, "chrome-extension://*/");

[Aaron Boodman, 2012/03/12 23:21:45]

Why?

[ericu, 2012/03/13 21:58:47]

Added a comment.

     URLPattern pattern(URLPattern::SCHEME_FILESYSTEM);
+    pattern.SetValidInnerSchemes(URLPattern::SCHEME_EXTENSION);
     if (pattern.Parse(filter) != URLPattern::PARSE_SUCCESS) {
       *error = ExtensionErrorUtils::FormatErrorMessageUTF16(
           errors::kInvalidURLPatternError, filter);
       return NULL;
     }
     std::string path = pattern.path();
-    bool allowed = path == "*" || path == "*.*" ||
-        (path.compare(0, 2, "*.") == 0 &&
-         path.find_first_of('*', 2) == std::string::npos);
+    bool allowed = path == "/*" || path == "/*.*" ||
+        (path.compare(0, 3, "/*.") == 0 &&
+         path.find_first_of('*', 3) == std::string::npos);
     if (!allowed) {
       *error = ExtensionErrorUtils::FormatErrorMessageUTF16(
           errors::kInvalidURLPatternError, filter);
       return NULL;
     }
     result->AddPattern(pattern);
   }
 
   std::string default_icon;
   // Read the file browser action |default_icon| (optional).
@@ skipping 2222 matching lines @@
     already_disabled(false),
     extension(extension) {}
 
 UpdatedExtensionPermissionsInfo::UpdatedExtensionPermissionsInfo(
     const Extension* extension,
     const ExtensionPermissionSet* permissions,
     Reason reason)
     : reason(reason),
       extension(extension),
       permissions(permissions) {}