Issue 7810025: Pass user_affiliation request parameter on user cloud policy requests.

Issue 7810025: Pass user_affiliation request parameter on user cloud policy requests. (Closed)

Created:
9 years, 3 months ago by Mattias Nissler (ping if slow)

Modified:
9 years, 3 months ago

Reviewers:
Joao da Silva, wtc

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Pass user_affiliation request parameter on user cloud policy requests. BUG=chromium-os:17809 TEST=Enroll device, login as an enterprise user, check user_affiliation parameter in policy requests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98987 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98996

Patch Set 3 : Fix Mac build breakage. #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -21 lines)			Patch
M	chrome/browser/policy/browser_policy_connector.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/browser_policy_connector.cc	View	1	2 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/cloud_policy_controller.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/cloud_policy_controller_unittest.cc	View		7 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/policy/cloud_policy_data_store.h	View	1 2	4 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/cloud_policy_data_store.cc	View	1 2	3 chunks	+12 lines, -1 line	0 comments	Download
M	chrome/browser/policy/device_management_backend.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/device_management_backend_impl.h	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/device_management_backend_impl.cc	View		6 chunks	+23 lines, -1 line	0 comments	Download
M	chrome/browser/policy/device_management_service_browsertest.cc	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	chrome/browser/policy/device_management_service_unittest.cc	View		3 chunks	+9 lines, -3 lines	0 comments	Download
M	chrome/browser/policy/enterprise_metrics_browsertest.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/policy/mock_device_management_backend.h	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/policy/mock_device_management_service.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/mock_device_management_service.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

LGTM http://codereview.chromium.org/7810025/diff/1/chrome/browser/policy/browser_policy_connector.cc File chrome/browser/policy/browser_policy_connector.cc (right): http://codereview.chromium.org/7810025/diff/1/chrome/browser/policy/browser_policy_connector.cc#newcode7 chrome/browser/policy/browser_policy_connector.cc:7: #include <string> Nit: already included in .h

9 years, 3 months ago (2011-08-31 15:14:43 UTC) #2

LGTM.  I only reviewed the diffs between Patch Sets 2 and 3.

Expand Messages | Collapse Messages