Issue 7810017: Revert 98938 - Migrate Obsolete NotificationsSettings and remove content_settings::NotificationsP...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7810017: Revert 98938 - Migrate Obsolete NotificationsSettings and remove content_settings::NotificationsP... (Closed)

Created:
9 years, 3 months ago by markusheintz_

Modified:
9 years, 3 months ago

Reviewers:
markusheintz_

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 98938 - Migrate Obsolete NotificationsSettings and remove content_settings::NotificationsProvider. BUG=63656 TEST=host_content_settings_map_unittest.cc, content_settings_pref_provider.cc, desktop_notifications_service_unittest.cc Review URL: http://codereview.chromium.org/7655019 TBR=markusheintz@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98941

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+491 lines, -498 lines)			Patch
A +	chrome/browser/content_settings/content_settings_notification_provider.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/content_settings/content_settings_notification_provider.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/content_settings/content_settings_pref_provider.h	View	4 chunks	+12 lines, -22 lines	0 comments	Download
M	chrome/browser/content_settings/content_settings_pref_provider.cc	View	17 chunks	+38 lines, -169 lines	0 comments	Download
M	chrome/browser/content_settings/content_settings_pref_provider_unittest.cc	View	3 chunks	+1 line, -138 lines	0 comments	Download
M	chrome/browser/content_settings/host_content_settings_map.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/content_settings/host_content_settings_map.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notification_service.h	View	6 chunks	+27 lines, -8 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notification_service.cc	View	9 chunks	+193 lines, -40 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notification_service_unittest.cc	View	6 chunks	+151 lines, -56 lines	0 comments	Download
M	chrome/browser/notifications/desktop_notifications_unittest.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/notification_exceptions_table_model.cc	View	6 chunks	+19 lines, -25 lines	0 comments	Download
M	chrome/browser/notifications/notification_exceptions_table_model_unittest.cc	View	3 chunks	+13 lines, -16 lines	0 comments	Download
M	chrome/browser/notifications/notification_options_menu_model.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
A +	chrome/browser/notifications/notifications_prefs_cache.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/notifications/notifications_prefs_cache.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/notifications/notifications_prefs_cache_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/prefs/browser_prefs.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/content_settings_handler.cc	View	4 chunks	+21 lines, -16 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages