Issue 7810014: Remove all excludes for 28439. Only valgrind bot(1) is failing and this must be something else.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7810014: Remove all excludes for 28439. Only valgrind bot(1) is failing and this must be something else. (Closed)

Created:
9 years, 3 months ago by oshima

Modified:
9 years, 3 months ago

Reviewers:
Timur Iskhodzhanov

CC:
chromium-reviews, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Put all tests that are exclude for 28439 back. Only valgrind bot(1) is failing and this must be something else. TBR=timurrr@chromium.org BUG=28439 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98914

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -34 lines)			Patch
	M	tools/valgrind/gtest_exclude/ui_tests.gtest_linux.txt	View		1 chunk	+0 lines, -34 lines	0 comments	Download

Total messages: 2 (0 generated)

Timur Iskhodzhanov

9 years, 3 months ago (2011-08-31 07:11:42 UTC) #2

LGTM, thanks!

I've rebooted the bot, let's see if it helps