Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 7810008: Remove incorrect assertion (Closed)

Created:
9 years, 3 months ago by brettw
Modified:
9 years, 3 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Remove incorrect assertion. This used to say DCHECK(!is_asynchronous_load_suspended || request_info_); When I made the request info a POD structure that's copied I should have just remove this check since that's really what it was testing. TEST=manual, no extra DCHECK hit BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98976

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M webkit/plugins/ppapi/ppb_url_loader_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
I think the PDF tests didn't show this because they're probably only run in release ...
9 years, 3 months ago (2011-08-30 23:23:40 UTC) #1
ddorwin
9 years, 3 months ago (2011-08-30 23:36:07 UTC) #2
LGTM.

Thanks. Actually, I think this is always false in the PDF case. It's other
plugins that do suspend load that would assert.

Powered by Google App Engine
This is Rietveld 408576698