Issue 7810007: [ntp4] More UI refinements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7810007: [ntp4] More UI refinements (Closed)

Created:
9 years, 3 months ago by csilv

Modified:
9 years, 3 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[ntp4] More UI refinements * Constraint favicon size for bookmarks & most-visited to 16x16. * Make color strip on bookmarks and most-visited full opacity. * Set padding space between icon and title for bookmarks & most-visited to 8px. (This CL is based on 7794005 which was reverted. The existing files remain the same, new changes are in favicon_webui_handler.cc.) BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99248

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -16 lines)			Patch
M	chrome/browser/resources/ntp4/bookmarks_page.css	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/ntp4/bookmarks_page.js	View	4 chunks	+18 lines, -3 lines	0 comments	Download
M	chrome/browser/resources/ntp4/most_visited_page.css	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/ntp4/most_visited_page.js	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/favicon_webui_handler.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

csilv

Evan, can you take a look at this one when you have a chance? I ...

9 years, 3 months ago (2011-09-01 02:45:01 UTC) #2

lgtm

Expand Messages | Collapse Messages