Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4277)

Unified Diff: chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm

Issue 7810002: Move infobar handling to a tab helper. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm
diff --git a/chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm b/chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm
index e377d18efcb6cf6726cc39d922123ffb4de0a951..69f2bb0c0dbf092bfe2eed41b6b5610bd6384f9a 100644
--- a/chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm
+++ b/chrome/browser/ui/cocoa/infobars/infobar_container_controller.mm
@@ -4,6 +4,7 @@
#include "base/logging.h"
#include "base/mac/mac_util.h"
+#include "chrome/browser/infobars/infobar_tab_helper.h"
#include "chrome/browser/tab_contents/confirm_infobar_delegate.h"
#include "chrome/browser/tab_contents/infobar.h"
#import "chrome/browser/ui/cocoa/animatable_view.h"
@@ -139,9 +140,11 @@ class InfoBarNotificationObserver : public NotificationObserver {
currentTabContents_ = contents;
if (currentTabContents_) {
- for (size_t i = 0; i < currentTabContents_->infobar_count(); ++i) {
- InfoBar* infobar = currentTabContents_->GetInfoBarDelegateAt(i)->
- CreateInfoBar(currentTabContents_);
+ for (size_t i = 0;
+ i < currentTabContents_->infobar_tab_helper()->infobar_count();
Peter Kasting 2011/08/31 18:47:32 Nit: Factor this infobar_tab_helper() out to a tem
+ ++i) {
+ InfoBar* infobar = currentTabContents_->infobar_tab_helper()->
+ GetInfoBarDelegateAt(i)->CreateInfoBar(currentTabContents_);
[self addInfoBar:infobar animate:NO];
}

Powered by Google App Engine
This is Rietveld 408576698