Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 7809024: Add ruby to the list of build dependencies so that WebKit's pretty diff utility (Closed)

Created:
9 years, 3 months ago by abarth%chromium.org
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add ruby to the list of build dependencies so that WebKit's pretty diff utility works on the buildbots. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99031

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/install-build-deps.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
9 years, 3 months ago (2011-08-31 18:17:23 UTC) #1
tony
LGTM
9 years, 3 months ago (2011-08-31 18:17:50 UTC) #2
commit-bot: I haz the power
9 years, 3 months ago (2011-08-31 20:22:19 UTC) #3
Presubmit check for 7809024-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
abarth%chromium.org@gtempaccount.com is not in AUTHORS file. If you are a new
contributor, please visit
http://www.chromium.org/developers/contributing-code and read the "Legal"
section
If you are a chromite, verify the contributor signed the CLA.

Presubmit checks took 2.9s to calculate.

Powered by Google App Engine
This is Rietveld 408576698