Remove Animation When "Resuming" Window in Lion

chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.h"
 
 #import "base/mac/mac_util.h"
 #include "base/mac/scoped_cftyperef.h"
 #import "chrome/browser/ui/cocoa/tabs/tab_controller.h"
 #import "chrome/browser/ui/cocoa/tabs/tab_controller_target.h"
@@ skipping 246 matching lines @@
         [sourceController_ detachTabToNewWindow:[draggedTab_ tabView]];
     dragWindow_ = [draggedController_ window];
     [dragWindow_ setAlphaValue:0.0];
     if (![sourceController_ hasLiveTabs]) {
       sourceController_ = draggedController_;
       sourceWindow_ = dragWindow_;
     }
 
     // Disable window animation before calling |orderFront:| when detatching
     // to a new window.
     NSWindowAnimationBehavior savedAnimationBehavior = 0;

[Mark Mentovai, 2011/08/31 18:47:01]

Get rid of the initializer like you did in the other file.

[dhollowa, 2011/08/31 18:57:17]

Done.

+    bool didSaveAnimationBehavior = false;
     if ([dragWindow_ respondsToSelector:@selector(animationBehavior)] &&
         [dragWindow_ respondsToSelector:@selector(setAnimationBehavior:)]) {
       savedAnimationBehavior = [dragWindow_ animationBehavior];
       [dragWindow_ setAnimationBehavior:NSWindowAnimationBehaviorNone];
+      didSaveAnimationBehavior = true;

[Mark Mentovai, 2011/08/31 18:47:01]

Move this one up like you did in the other file.

[dhollowa, 2011/08/31 18:57:17]

Done.

     }
 
     // If dragging the tab only moves the current window, do not show overlay
     // so that sheets stay on top of the window.
     // Bring the target window to the front and make sure it has a border.
     [dragWindow_ setLevel:NSFloatingWindowLevel];
     [dragWindow_ setHasShadow:YES];
     [dragWindow_ orderFront:nil];
     [dragWindow_ makeMainWindow];
     [draggedController_ showOverlay];
     dragOverlay_ = [draggedController_ overlayWindow];
     // Force the new tab button to be hidden. We'll reset it on mouse up.
     [draggedController_ showNewTabButton:NO];
     tearTime_ = [NSDate timeIntervalSinceReferenceDate];
     tearOrigin_ = sourceWindowFrame_.origin;
 
-    // Restore window animation behavior
-    if ([dragWindow_ respondsToSelector:@selector(animationBehavior)] &&
-        [dragWindow_ respondsToSelector:@selector(setAnimationBehavior:)]) {
+    // Restore window animation behavior.
+    if (didSaveAnimationBehavior)
       [dragWindow_ setAnimationBehavior:savedAnimationBehavior];
-    }
   }
 
   // TODO(pinkerton): http://crbug.com/25682 demonstrates a way to get here by
   // some weird circumstance that doesn't first go through mouseDown:. We
   // really shouldn't go any farther.
   if (!draggedController_ || !sourceController_)
     return;
 
   // When the user first tears off the window, we want slide the window to
   // the current mouse location (to reduce the jarring appearance). We do this
@@ skipping 246 matching lines @@
       NOTREACHED();
     }
   }
   if (useCache) {
     workspaceIDCache_[windowID] = workspace;
   }
   return workspace;
 }
 
 @end