Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 7807: SCons renaming updates for base, net and googleurl:... (Closed)

Created:
12 years, 2 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
tony, bradn
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

SCons renaming updates for base, net and googleurl: * Rename SConscript files to {module}.scons or {moduel}_lib.scons, depending on the primary target involved. * Separate targets into individual *.scons files, with one construction environment (named "env") per *.scons file. * Add using_{module}.scons files (like .vsprops) that will be used by other modules to add CPPDEFINES, CPPPATH, LIBS and LIBPATH values. * Update other modules' *.scons files to use the new using_{module}.scons files (using a temporary one-liner idiom until we have the ApplySConscript() method from the Hammer modules). * Use the idiom of removing to-be-ported files from the master list, so they can be simply deleted from the to-be-ported list as they get ported in the future, instead of having to shuffle entries between lists. * Use $OBJ_ROOT instead of hard-coded '#/$BUILD_TYPE/' for the $*_DIR variables. * Add a addRepository() call mapping build/ to $TARGET_ROOT/googleurl, so its $OBJ_ROOT value can look like the others'. * Formatting changes, primarily modifying indentation to conform to style guidelines. * Fix copyright headers in some third_party/* modules previously overlooked. * Add rudimentary __doc__ strings, setting up for a future ability to generate meaningful documentation. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3675

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1113 lines, -1872 lines) Patch
D base/SConscript View 1 2 1 chunk +0 lines, -360 lines 0 comments Download
A base/base.scons View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
A + base/base_lib.scons View 1 2 9 chunks +27 lines, -199 lines 0 comments Download
A base/base_unittests.scons View 1 2 1 chunk +171 lines, -0 lines 0 comments Download
D base/gfx/SConscript View 1 2 1 chunk +0 lines, -77 lines 0 comments Download
A + base/gfx/base_gfx.scons View 1 2 2 chunks +40 lines, -38 lines 0 comments Download
A base/gfx/using_base_gfx.scons View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A base/using_base.scons View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M build/SConscript.googleurl View 1 2 1 chunk +0 lines, -95 lines 0 comments Download
M build/SConscript.main View 1 2 8 chunks +14 lines, -22 lines 0 comments Download
A build/googleurl.scons View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A build/googleurl_lib.scons View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
A build/googleurl_unittests.scons View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
A build/using_googleurl.scons View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
D net/SConscript View 1 2 1 chunk +0 lines, -356 lines 0 comments Download
A net/crash_cache.scons View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
A net/net.scons View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
A + net/net_lib.scons View 1 2 7 chunks +41 lines, -206 lines 0 comments Download
A net/net_perftests.scons View 1 2 1 chunk +76 lines, -0 lines 0 comments Download
A net/net_resources.scons View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
A net/net_unittests.scons View 1 2 1 chunk +125 lines, -0 lines 0 comments Download
A net/stress_cache.scons View 1 2 1 chunk +62 lines, -0 lines 0 comments Download
D net/tools/tld_cleanup/SConscript View 1 2 1 chunk +0 lines, -52 lines 0 comments Download
A + net/tools/tld_cleanup/tld_cleanup.scons View 1 2 1 chunk +34 lines, -32 lines 0 comments Download
A net/using_net.scons View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A sdch/using_sdch.scons View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M skia/SConscript View 1 2 1 chunk +1 line, -1 line 0 comments Download
A skia/using_skia.scons View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
A testing/using_gtest.scons View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
D third_party/bzip2/SConscript View 1 2 1 chunk +0 lines, -60 lines 0 comments Download
A + third_party/bzip2/bzip2.scons View 1 2 1 chunk +7 lines, -29 lines 0 comments Download
A third_party/bzip2/using_bzip2.scons View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
D third_party/libevent/SConscript View 1 2 1 chunk +0 lines, -72 lines 0 comments Download
A + third_party/libevent/libevent.scons View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
A third_party/libevent/using_libevent.scons View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
D third_party/libpng/SConscript View 1 2 1 chunk +0 lines, -77 lines 0 comments Download
A + third_party/libpng/libpng.scons View 1 2 1 chunk +13 lines, -31 lines 0 comments Download
A third_party/libpng/using_libpng.scons View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
D third_party/modp_b64/SConscript View 1 2 1 chunk +0 lines, -46 lines 0 comments Download
A + third_party/modp_b64/modp_b64.scons View 1 2 2 chunks +8 lines, -29 lines 0 comments Download
A third_party/modp_b64/using_modp_b64.scons View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
D third_party/zlib/SConscript View 1 2 1 chunk +0 lines, -58 lines 0 comments Download
A third_party/zlib/using_zlib.scons View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A + third_party/zlib/zlib.scons View 1 2 1 chunk +7 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sgk
Draft for review while I finish details. I'll make a final editing pass tomorrow morning ...
12 years, 2 months ago (2008-10-21 07:31:47 UTC) #1
bradn
LGTM, though it looks like it hasn't been integrated with mainline?
12 years, 2 months ago (2008-10-21 17:07:12 UTC) #2
tony
rubber stamp LGTM, please verify on the linux try bot.
12 years, 2 months ago (2008-10-21 17:53:37 UTC) #3
sgk
12 years, 2 months ago (2008-10-21 19:50:45 UTC) #4
Updated with copyright header fixes, doc strings.

Try bot can't apply the patch because of the moved files.  I plan to submit
(based on the rebuilds I can do), and be ready to revert at the first sign of
trouble.

Powered by Google App Engine
This is Rietveld 408576698