Issue 7806020: Add DeletePluginInDeallocate UI test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7806020: Add DeletePluginInDeallocate UI test. (Closed)

Created:
9 years, 3 months ago by Wez

Modified:
9 years, 3 months ago

Reviewers:
eroman, ananta

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add DeletePluginInDeallocate UI test. BUG=94179 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99762

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix issues signalling test completion. #

Patch Set 3 : Address comment. #

Patch Set 4 : Move script into head. #

Patch Set 5 : Rebase, #

Patch Set 6 : Correct Copyright header. #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+259 lines, -3 lines)			Patch
A	chrome/test/data/npapi/plugin_delete_in_deallocate.html	View	1 2 3	1 chunk	+55 lines, -0 lines	0 comments	Download
M	chrome/test/ui/npapi_test_helper.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/test/ui/npapi_uitest.cc	View	1	2 chunks	+14 lines, -2 lines	0 comments	Download
A	webkit/plugins/npapi/test/plugin_delete_plugin_in_deallocate_test.h	View	1 2	1 chunk	+30 lines, -0 lines	0 comments	Download
A	webkit/plugins/npapi/test/plugin_delete_plugin_in_deallocate_test.cc	View	1 2	1 chunk	+151 lines, -0 lines	0 comments	Download
M	webkit/plugins/npapi/test/plugin_test_factory.cc	View	1 2 3 4 5	3 chunks	+4 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell.gypi	View	1 2 3 4 5	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Wez

Add a UI test to verify that we don't double-free a plugin NPAPI object if ...

9 years, 3 months ago (2011-08-30 18:12:50 UTC) #1

eroman

9 years, 3 months ago (2011-08-30 18:54:25 UTC) #3

LGTM thanks!

http://codereview.chromium.org/7806020/diff/1/webkit/plugins/npapi/test/plugi...
File webkit/plugins/npapi/test/plugin_delete_plugin_in_deallocate_test.h
(right):

http://codereview.chromium.org/7806020/diff/1/webkit/plugins/npapi/test/plugi...
webkit/plugins/npapi/test/plugin_delete_plugin_in_deallocate_test.h:18:
DeletePluginInDeallocateTest(NPP id, NPNetscapeFuncs *host_functions);
Nit: Move the asterisk to the left, as in NPNetscapeFuncs*

Expand Messages | Collapse Messages