Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 7806015: Adds some debugging code to figure out why we crash when showing the (Closed)

Created:
9 years, 3 months ago by sky
Modified:
9 years, 3 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Visibility:
Public.

Description

Adds some debugging code to figure out why we crash when showing the omnibox in some cases. I suspect the call to the IME code is triggering a window to show, resulting in losing focus, closing the omnbox and crashing. But this will verify that's happening. BUG=92497 TEST=none R=pkasting@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98922

Patch Set 1 #

Patch Set 2 : Add setting value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/autocomplete/autocomplete_popup_contents_view.cc View 1 6 chunks +21 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
9 years, 3 months ago (2011-08-30 16:26:06 UTC) #1
Peter Kasting
9 years, 3 months ago (2011-08-30 20:14:13 UTC) #2
Rubber-stamp LGTM... my brain is somehow not following what you're doing here,
but I trust you

Powered by Google App Engine
This is Rietveld 408576698