Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 7806011: Add a dependency of v8_base on WinSocket2 Windows library. (Closed)

Created:
9 years, 3 months ago by mnaganov (inactive)
Modified:
9 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Add a dependency of v8_base on WinSocket2 Windows library. v8_base depends on ws2_32.lib for accept() and some of the other socket used for the debugger. Patch by Ryan Dahl <ry@tinyclouds.org>; R=jkummerow@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=9069

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/gyp/v8.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Jakob Kummerow
9 years, 3 months ago (2011-08-30 11:07:45 UTC) #1
LGTM. Thanks!

Powered by Google App Engine
This is Rietveld 408576698