Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 7806010: Fix small memory leak on SysAllocString. (Closed)

Created:
9 years, 3 months ago by yosin_UTC9
Modified:
9 years, 3 months ago
CC:
chromium-reviews, dhollowa
Visibility:
Public.

Description

* Fix small memory leak on SysAllocString. ** Use IAccPropServices::SetHwndPropStr == no more BSTR * Change for cpplint.py Caller owns BSTR on call: http://www.codeguru.com/forum/showthread.php?t=364511 BUG=n/a TEST=Use Task Manager for monitoring memory usage after setting long title with document.title Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98940

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use IAccPropServices::SetHwndPropStr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M views/widget/native_widget_win.cc View 1 5 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yosin_UTC9
Could you review my change? Thanks in advance. -yosi P.S. I found this memory leak ...
9 years, 3 months ago (2011-08-30 08:04:40 UTC) #1
sky
http://codereview.chromium.org/7806010/diff/1/views/widget/native_widget_win.cc File views/widget/native_widget_win.cc (right): http://codereview.chromium.org/7806010/diff/1/views/widget/native_widget_win.cc#newcode698 views/widget/native_widget_win.cc:698: hr = pAccPropServices->SetHwndProp(GetNativeView(), OBJID_CLIENT, Could we simplify this to ...
9 years, 3 months ago (2011-08-30 15:35:23 UTC) #2
yosin_UTC9
Could you review again? Thanks in advance. -yosi
9 years, 3 months ago (2011-08-31 05:28:58 UTC) #3
sky
Nice, LGTM
9 years, 3 months ago (2011-08-31 05:36:03 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-08-31 08:24:02 UTC) #5
Change committed as 98940

Powered by Google App Engine
This is Rietveld 408576698