Issue 7806002: Fix ChunkDemuxer end of stream handling.

Issue 7806002: Fix ChunkDemuxer end of stream handling. (Closed)

Created:
9 years, 3 months ago by acolwell GONE FROM CHROMIUM

Modified:
9 years, 3 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Paweł Hajdan Jr., acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix ChunkDemuxer end of stream handling. BUG=86536 TEST=ChunkDemuxerTest.TestReadsAfterEndOfStream, ChunkDemuxerTest.TestEndOfStreamWithPendingReads Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98880

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix nit and added helper class to reduce duplicated code. #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+163 lines, -5 lines)			Patch
	M	media/filters/chunk_demuxer.cc	View		6 chunks	+20 lines, -5 lines	0 comments	Download
	M	media/filters/chunk_demuxer_unittest.cc	View	1	1 chunk	+143 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

LGTM w/ nit http://codereview.chromium.org/7806002/diff/1/media/filters/chunk_demuxer_unittest.cc File media/filters/chunk_demuxer_unittest.cc (right): http://codereview.chromium.org/7806002/diff/1/media/filters/chunk_demuxer_unittest.cc#newcode543 media/filters/chunk_demuxer_unittest.cc:543: bool audio_read_done_1 = false; I wonder ...

9 years, 3 months ago (2011-08-30 00:59:52 UTC) #2

acolwell GONE FROM CHROMIUM

9 years, 3 months ago (2011-08-30 17:01:45 UTC) #3

http://codereview.chromium.org/7806002/diff/1/media/filters/chunk_demuxer_uni...
File media/filters/chunk_demuxer_unittest.cc (right):

http://codereview.chromium.org/7806002/diff/1/media/filters/chunk_demuxer_uni...
media/filters/chunk_demuxer_unittest.cc:543: bool audio_read_done_1 = false;
On 2011/08/30 00:59:52, scherkus wrote:
> I wonder if there's a more terse way to write these tests but it's not obvious
> to me how -- perhaps a helper class of some sort

Done.

http://codereview.chromium.org/7806002/diff/1/media/filters/chunk_demuxer_uni...
media/filters/chunk_demuxer_unittest.cc:607: 
On 2011/08/30 00:59:52, scherkus wrote:
> nit: blank line

Done.

Expand Messages | Collapse Messages