Issue 7806: Rename SConscript to icu38.scons. Add a using_icu38.scons (like...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7806: Rename SConscript to icu38.scons. Add a using_icu38.scons (like... (Closed)

Created:
12 years, 2 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
tony, bradn

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Rename SConscript to icu38.scons. Add a using_icu38.scons (like .vsprops) that other modules can use to add CPPPATH directories, CPPDEFINES and LIBS. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3658

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -452 lines)			Patch
D	third_party/icu38/SConscript	View	1 chunk	+0 lines, -453 lines	0 comments	Download
A +	third_party/icu38/icu38.scons	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	third_party/icu38/using_icu38.scons	View	1 chunk	+18 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

sgk

Change to icu38 first, since it's separate from the rest. If this and the next ...

12 years, 2 months ago (2008-10-21 07:28:13 UTC) #1

LGTM2