Issue 78002: Reorganize fullscreen mode handling. Now nearly everything is in WindowWin. ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 78002: Reorganize fullscreen mode handling. Now nearly everything is in WindowWin. ... (Closed)

Created:
11 years, 8 months ago by Peter Kasting

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Reorganize fullscreen mode handling. Now nearly everything is in WindowWin. This also includes work area change notifications, which only really apply to Windows (and not pure Widgets) anyway. Some parts (namely, the browser-specific things) are still in BrowserView.This allows me to fix the bug where unlocking your screen resized fullscreen mode windows incorrectly.There are probably one or two other small bits tangled in here -- this got a bit messy. I moved the exit bubble out of browser/ because it wasn't browser-specific; in theory, any WindowWin can now go into fullscreen mode.BUG=8159 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=13908

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+343 lines, -271 lines)			Patch
M	chrome/browser/views/frame/browser_frame.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.h	View	1	3 chunks	+0 lines, -20 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	1 2 3	13 chunks	+39 lines, -97 lines	0 comments	Download
M	chrome/browser/views/frame/glass_browser_frame_view.cc	View		2 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/views/frame/opaque_browser_frame_view.cc	View		6 chunks	+10 lines, -7 lines	0 comments	Download
M	chrome/browser/window_sizer.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/common/win_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/views/widget/widget_win.h	View		4 chunks	+16 lines, -19 lines	0 comments	Download
M	chrome/views/widget/widget_win.cc	View		6 chunks	+1 line, -100 lines	0 comments	Download
M	chrome/views/window/window.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/views/window/window_win.h	View	1	7 chunks	+49 lines, -6 lines	0 comments	Download
M	chrome/views/window/window_win.cc	View	1 2 3	11 chunks	+205 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages

Issue 78002: Reorganize fullscreen mode handling. Now nearly everything is in WindowWin. ... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages