Fixing EOLs.

Fixing EOLs.

This fixes a file that was committed with Windows-style EOLs.

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99747

[Randy Smith (Not in Mondays), 2011-09-06 16:11:51]

LGTM.  I'll note that no matter how I look at this (including with od) I can't
see the newline change.  I presume (given that there is some change shown and no
other characters have changed) that this means that Rietveld doesn't notice
those changes even at the raw patchset level but that the change is actually
there.  But I can see why this has to go in through dcommit; if Rietveld doesn't
get it, the try bots probably won't either.

[jam, 2011-09-06 16:23:23]

On 2011/09/06 16:11:51, rdsmith wrote:
> LGTM.  I'll note that no matter how I look at this (including with od) I can't
> see the newline change.  I presume (given that there is some change shown and
no
> other characters have changed) that this means that Rietveld doesn't notice
> those changes even at the raw patchset level but that the change is actually
> there.  But I can see why this has to go in through dcommit; if Rietveld
doesn't
> get it, the try bots probably won't either.

I'm confused how this can happen. That file is set to unix line endings, so any
commit should force the new lines characters to be LF only.

A:\chrome3\src>svn propget "svn:eol-style" content\browser\download\base_file.cc
LF

[ahendrickson, 2011-09-06 16:29:34]

On 2011/09/06 16:23:23, John Abd-El-Malek wrote:
> On 2011/09/06 16:11:51, rdsmith wrote:
> > LGTM.  I'll note that no matter how I look at this (including with od) I
can't
> > see the newline change.  I presume (given that there is some change shown
and
> no
> > other characters have changed) that this means that Rietveld doesn't notice
> > those changes even at the raw patchset level but that the change is actually
> > there.  But I can see why this has to go in through dcommit; if Rietveld
> doesn't
> > get it, the try bots probably won't either.
> 
> I'm confused how this can happen. That file is set to unix line endings, so
any
> commit should force the new lines characters to be LF only.
> 
> A:\chrome3\src>svn propget "svn:eol-style"
content\browser\download\base_file.cc
> LF

This is what I get when I try:

[Tue Sep 06 12:27:05] ahendrickson@AHENDRICKSON0-W
/cygdrive/d/chromiumtrunk/cr1/src *trunk*
$  svn propget "svn:eol-style" content\browser\download\base_file.cc
svn: '.' is not a working copy

I'm on Windows 7, running under Cygwin.

Do I have something set up improperly?

[jam, 2011-09-06 17:47:40]

On Tue, Sep 6, 2011 at 9:29 AM, <ahendrickson@chromium.org> wrote:

> On 2011/09/06 16:23:23, John Abd-El-Malek wrote:
>
>> On 2011/09/06 16:11:51, rdsmith wrote:
>> > LGTM.  I'll note that no matter how I look at this (including with od) I
>>
> can't
>
>> > see the newline change.  I presume (given that there is some change
>> shown
>>
> and
>
>> no
>> > other characters have changed) that this means that Rietveld doesn't
>> notice
>> > those changes even at the raw patchset level but that the change is
>> actually
>> > there.  But I can see why this has to go in through dcommit; if Rietveld
>> doesn't
>> > get it, the try bots probably won't either.
>>
>
>  I'm confused how this can happen. That file is set to unix line endings,
>> so
>>
> any
>
>> commit should force the new lines characters to be LF only.
>>
>
>  A:\chrome3\src>svn propget "svn:eol-style"
>>
> content\browser\download\base_**file.cc
>
>> LF
>>
>
> This is what I get when I try:
>
> [Tue Sep 06 12:27:05] ahendrickson@AHENDRICKSON0-W
> /cygdrive/d/chromiumtrunk/cr1/**src *trunk*
> $  svn propget "svn:eol-style" content\browser\download\base_**file.cc
> svn: '.' is not a working copy
>
> I'm on Windows 7, running under Cygwin.
>
> Do I have something set up improperly?


If svn isn't working for you, then it seems that something is definitely not
setup properly. I don't use svn under cygwin, just under command prompt.
What happens if you try it there?

>
>
>
>
http://codereview.chromium.**org/7800043/<http://codereview.chromium.org/7800...
>

[ahendrickson, 2011-09-06 18:25:07]

On 2011/09/06 17:47:40, John Abd-El-Malek wrote:
> If svn isn't working for you, then it seems that something is definitely not
> setup properly. I don't use svn under cygwin, just under command prompt.
> What happens if you try it there?

D:\chromiumtrunk\cr1\src>svn propget "svn:eol-style"
content\browser\download\base_file.cc
'svn' is not recognized as an internal or external command,
operable program or batch file.