Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 7800039: Adding yasm_include.gypi to reuse rules for compiling assembly files (Closed)

Created:
9 years, 3 months ago by Alpha Left Google
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Adding yasm_include.gypi to reuse rules for compiling assembly files There are a couple spots where we use YASM and this change is a start to organize the usage of YASM in chromium tree. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99751

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -0 lines) Patch
A third_party/yasm/yasm_compile.gypi View 1 chunk +97 lines, -0 lines 6 comments Download

Messages

Total messages: 3 (0 generated)
Alpha Left Google
9 years, 3 months ago (2011-09-06 16:44:35 UTC) #1
scherkus (not reviewing)
LGTM w/ nits http://codereview.chromium.org/7800039/diff/1/third_party/yasm/yasm_compile.gypi File third_party/yasm/yasm_compile.gypi (right): http://codereview.chromium.org/7800039/diff/1/third_party/yasm/yasm_compile.gypi#newcode15 third_party/yasm/yasm_compile.gypi:15: # 'ultra_optimized_awsome.asm', awsome -> awesome :) ...
9 years, 3 months ago (2011-09-06 16:51:13 UTC) #2
Alpha Left Google
9 years, 3 months ago (2011-09-06 17:12:13 UTC) #3
http://codereview.chromium.org/7800039/diff/1/third_party/yasm/yasm_compile.gypi
File third_party/yasm/yasm_compile.gypi (right):

http://codereview.chromium.org/7800039/diff/1/third_party/yasm/yasm_compile.g...
third_party/yasm/yasm_compile.gypi:15: #   'ultra_optimized_awsome.asm',
On 2011/09/06 16:51:13, scherkus wrote:
> awsome -> awesome :)

Done.

http://codereview.chromium.org/7800039/diff/1/third_party/yasm/yasm_compile.g...
third_party/yasm/yasm_compile.gypi:18: #   'yasm_flags': [
On 2011/09/06 16:51:13, scherkus wrote:
> does including a gypi do a dictionary merge or a clobber?
> 
> for example, would -I get overwritten by the yasm_flags declared below?

It'll be a merge.

http://codereview.chromium.org/7800039/diff/1/third_party/yasm/yasm_compile.g...
third_party/yasm/yasm_compile.gypi:71: # .asm files for ARM will fail.
On 2011/09/06 16:51:13, scherkus wrote:
> interesting... I thought we were using YASM for ARM for FFmpeg

YASM doesn't compile ARM code, it's for x86 only. For ARM it's the .S/.s files
which get compiled by gcc.

Powered by Google App Engine
This is Rietveld 408576698