Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 7800036: Print Preview: Hold on to tabs that do window.print(); window.close() until print preview finishes. (Closed)

Created:
9 years, 3 months ago by Lei Zhang
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Print Preview: Hold on to tabs that do window.print(); window.close() until print preview finishes. BUG=87362 TEST=Create html file with window.print(); window.close(); and then print, cancel or close the print tab. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100235

Patch Set 1 #

Total comments: 14

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -26 lines) Patch
M chrome/browser/printing/background_printing_manager.h View 1 4 chunks +27 lines, -0 lines 0 comments Download
M chrome/browser/printing/background_printing_manager.cc View 1 4 chunks +151 lines, -26 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Lei Zhang
This is the follow up to http://codereview.chromium.org/7574002/ - Already checked in some of the cleanup ...
9 years, 3 months ago (2011-09-06 17:06:04 UTC) #1
kmadhusu
http://codereview.chromium.org/7800036/diff/1/chrome/browser/printing/background_printing_manager.cc File chrome/browser/printing/background_printing_manager.cc (right): http://codereview.chromium.org/7800036/diff/1/chrome/browser/printing/background_printing_manager.cc#newcode143 chrome/browser/printing/background_printing_manager.cc:143: MessageLoop::current()->DeleteSoon(FROM_HERE, tab); When exactly multiple preview tabs share the ...
9 years, 3 months ago (2011-09-07 23:21:09 UTC) #2
Lei Zhang
http://codereview.chromium.org/7800036/diff/1/chrome/browser/printing/background_printing_manager.cc File chrome/browser/printing/background_printing_manager.cc (right): http://codereview.chromium.org/7800036/diff/1/chrome/browser/printing/background_printing_manager.cc#newcode143 chrome/browser/printing/background_printing_manager.cc:143: MessageLoop::current()->DeleteSoon(FROM_HERE, tab); On 2011/09/07 23:21:10, kmadhusu wrote: > When ...
9 years, 3 months ago (2011-09-07 23:41:16 UTC) #3
kmadhusu
LGTM
9 years, 3 months ago (2011-09-08 00:55:49 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-09-08 20:34:55 UTC) #5
Change committed as 100235

Powered by Google App Engine
This is Rietveld 408576698