Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 7800035: Fix scons compile in Native Client on Windows. (Closed)

Created:
9 years, 3 months ago by halyavin
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix scons compile in Native Client on Windows. BUG=95475 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99744

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
halyavin
9 years, 3 months ago (2011-09-06 09:12:24 UTC) #1
sehr (please use chromium)
One coding convention issue. Fix and LGTM. http://codereview.chromium.org/7800035/diff/1/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc File ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc (right): http://codereview.chromium.org/7800035/diff/1/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc#newcode80 ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc:80: static const ...
9 years, 3 months ago (2011-09-06 14:57:13 UTC) #2
halyavin
http://codereview.chromium.org/7800035/diff/1/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc File ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc (right): http://codereview.chromium.org/7800035/diff/1/ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc#newcode80 ppapi/native_client/src/shared/ppapi_proxy/browser_ppb_graphics_3d_rpc_server.cc:80: static const PPB_GpuBlacklist_Private* GpuBlacklist_interface = On 2011/09/06 14:57:13, sehr ...
9 years, 3 months ago (2011-09-06 14:59:58 UTC) #3
commit-bot: I haz the power
9 years, 3 months ago (2011-09-06 16:10:34 UTC) #4
Change committed as 99744

Powered by Google App Engine
This is Rietveld 408576698