prune down content_dll change to just the CONTENT_EXPORTS

content/browser/appcache/chrome_appcache_service.h

Index: content/browser/appcache/chrome_appcache_service.h
diff --git a/content/browser/appcache/chrome_appcache_service.h b/content/browser/appcache/chrome_appcache_service.h
index 51829f94c1271ea921bde05fc028a93ec95c9751..4c614e7c04592bbb199cafdde40d7ab0deac3eb2 100644
--- a/content/browser/appcache/chrome_appcache_service.h
+++ b/content/browser/appcache/chrome_appcache_service.h
@@ -6,8 +6,10 @@
 #define CONTENT_BROWSER_APPCACHE_CHROME_APPCACHE_SERVICE_H_
 #pragma once
 
+#include "base/compiler_specific.h"
 #include "base/memory/ref_counted.h"
 #include "content/browser/browser_thread.h"
+#include "content/common/content_export.h"
 #include "content/common/notification_observer.h"
 #include "content/common/notification_registrar.h"
 #include "webkit/appcache/appcache_policy.h"
@@ -28,11 +30,11 @@ class ResourceContext;
 //
 // All methods, except the ctor, are expected to be called on
 // the IO thread (unless specifically called out in doc comments).
-class ChromeAppCacheService
+class CONTENT_EXPORT ChromeAppCacheService
     : public base::RefCountedThreadSafe<ChromeAppCacheService,
                                         BrowserThread::DeleteOnIOThread>,
-      public appcache::AppCacheService,
-      public appcache::AppCachePolicy,
+      NON_EXPORTED_BASE(public appcache::AppCacheService),

[darin (slow to review), 2011/09/04 15:41:04]

the risk here is that someone outside of content might start calling these
public base class methods.  that would then break linking in the component
build.  is it necessary to extend from AppCacheService, or can it be made a
member variable instead?  Alternatively, can it use private inheritance (against
the style guide rules, I know)?

actually, this is really only an issue for AppCacheService since AppCachePolicy
just has pure virtual methods.

[Dirk Pranke, 2011/09/07 01:46:07]

I will add a TODO for now and come back to this in a later patch.

+      NON_EXPORTED_BASE(public appcache::AppCachePolicy),
       public NotificationObserver {
  public:
   explicit ChromeAppCacheService(quota::QuotaManagerProxy* proxy);
@@ -43,6 +45,8 @@ class ChromeAppCacheService
       scoped_refptr<quota::SpecialStoragePolicy> special_storage_policy);
 
  private:
+  friend base::RefCountedThreadSafe<ChromeAppCacheService,
+                                    BrowserThread::DeleteOnIOThread>;
   friend class BrowserThread;
   friend class DeleteTask<ChromeAppCacheService>;