Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 7800015: prune down content_dll change to just the CONTENT_EXPORTS (Closed)

Created:
9 years, 3 months ago by Dirk Pranke
Modified:
9 years, 3 months ago
CC:
chromium-reviews, jam, yoshiki+watch_chromium.org, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, kinuko+watch, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, achuith+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, Avi (use Gerrit), dtseng+watch_chromium.org, yuzo+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, michaeln, hashimoto+watch_chromium.org, davidbarr+watch_chromium.org, rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Annotate all of the functions in content that need to be exported, in preparation for creating a content shared library. R=darin@chromium.org, jam@chromium.org, willchan@chromium.org BUG=90442 TEST=everything still compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100975

Patch Set 1 #

Patch Set 2 : linting #

Patch Set 3 : rebase to r99460 so try jobs might work #

Patch Set 4 : fix exports for switches, content_main #

Total comments: 36

Patch Set 5 : update w/ review feedback #

Patch Set 6 : disable component_build for content #

Patch Set 7 : fix more export declarations to fix linux,mac compiles #

Patch Set 8 : update copyright headers, merge #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+569 lines, -353 lines) Patch
M content/app/content_main.h View 1 2 3 4 5 6 7 2 chunks +7 lines, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_state.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/appcache/chrome_appcache_service.h View 1 2 3 4 5 6 7 3 chunks +10 lines, -3 lines 0 comments Download
M content/browser/browser_child_process_host.h View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/browser_message_filter.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/browser_thread.h View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/browser_url_handler.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/browsing_instance.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/cancelable_request.h View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/cert_store.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/child_process_launcher.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/child_process_security_policy.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/chrome_blob_storage_context.h View 3 chunks +4 lines, -1 line 0 comments Download
M content/browser/debugger/devtools_agent_host.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/debugger/devtools_client_host.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/debugger/devtools_http_protocol_handler.h View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/debugger/devtools_manager.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/disposition_utils.h View 2 chunks +6 lines, -5 lines 0 comments Download
M content/browser/download/base_file.h View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/download/download_file.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/download/download_file_manager.h View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/download/download_item.h View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/download/download_manager.h View 1 2 3 4 5 6 4 chunks +5 lines, -2 lines 0 comments Download
M content/browser/download/download_persistent_store_info.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/download/download_state_info.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/download/download_stats.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/download/download_status_updater.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/download/download_status_updater_delegate.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/download/drag_download_file.h View 1 2 3 4 5 6 2 chunks +7 lines, -3 lines 0 comments Download
M content/browser/download/drag_download_util.h View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/download/mhtml_generation_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/download/save_file_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/download/save_package.h View 1 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/file_system/browser_file_system_helper.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/font_list_async.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/geolocation/access_token_store.h View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/geolocation/geolocation_permission_context.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/geolocation/geolocation_provider.h View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_blacklist.h View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_data_manager.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.h View 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/host_zoom_map.h View 1 2 3 4 5 6 7 3 chunks +4 lines, -1 line 0 comments Download
M content/browser/in_process_webkit/dom_storage_context.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_context.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/in_process_webkit/indexed_db_key_utility_client.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/in_process_webkit/session_storage_namespace.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/in_process_webkit/webkit_context.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/javascript_dialogs.h View 3 chunks +3 lines, -2 lines 0 comments Download
content/browser/net/browser_online_state_observer.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/net/url_request_failed_dns_job.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/net/url_request_mock_http_job.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/net/url_request_slow_download_job.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/net/url_request_slow_http_job.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/plugin_service.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/backing_store_manager.h View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/backing_store_skia.h View 2 chunks +7 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_factory.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_observer.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_fullscreen_host.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view.h View 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.h View 3 chunks +6 lines, -4 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_login_delegate.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_request_info.h View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/resource_queue.h View 1 2 3 4 5 6 7 4 chunks +5 lines, -4 lines 0 comments Download
M content/browser/resource_context.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/site_instance.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/speech/speech_input_manager.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/speech/speech_recognizer.h View 2 chunks +11 lines, -10 lines 0 comments Download
M content/browser/ssl/ssl_client_auth_handler.h View 1 2 3 4 5 6 4 chunks +5 lines, -2 lines 0 comments Download
content/browser/ssl/ssl_error_handler.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/ssl/ssl_host_state.h View 1 2 3 4 5 6 7 3 chunks +5 lines, -2 lines 0 comments Download
M content/browser/ssl/ssl_manager.h View 3 chunks +7 lines, -6 lines 0 comments Download
M content/browser/tab_contents/interstitial_page.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tab_contents/navigation_controller.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/navigation_details.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/navigation_entry.h View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tab_contents/page_navigator.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 2 3 4 5 6 7 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/tab_contents/tab_contents_delegate.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents_observer.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents_view.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/trace_controller.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/user_metrics.h View 1 2 3 4 5 6 7 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/utility_process_host.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/webui/web_ui.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -2 lines 0 comments Download
M content/common/child_process.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/child_process_host.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M content/common/child_process_info.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/child_process_messages.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/child_thread.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/common/common_param_traits.h View 10 chunks +10 lines, -9 lines 0 comments Download
content/common/content_client.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/common/content_constants.h View 1 2 3 4 5 6 7 2 chunks +5 lines, -3 lines 0 comments Download
M content/common/content_counters.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/common/content_export.h View 1 2 3 4 5 6 7 1 chunk +1 line, -2 lines 0 comments Download
M content/common/content_paths.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/common/content_switches.h View 1 2 3 4 5 6 7 3 chunks +69 lines, -63 lines 0 comments Download
M content/common/devtools_messages.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_feature_flags.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/common/hi_res_timer_manager.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/common/json_value_serializer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/common/native_web_keyboard_event.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/common/net/url_fetcher.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -2 lines 0 comments Download
M content/common/notification_details.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/notification_observer.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/common/notification_registrar.h View 1 2 3 4 5 6 7 3 chunks +3 lines, -2 lines 0 comments Download
M content/common/notification_service.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M content/common/notification_source.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/page_transition_types.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/common/pepper_plugin_registry.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/common/plugin_messages.h View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/property_bag.h View 3 chunks +3 lines, -2 lines 0 comments Download
M content/common/renderer_preferences.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/common/resource_dispatcher_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/resource_response.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/common/sandbox_init_wrapper.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/common/sandbox_policy.h View 1 2 3 4 5 6 7 3 chunks +7 lines, -4 lines 0 comments Download
M content/common/section_util_win.h View 1 2 3 4 2 chunks +6 lines, -1 line 0 comments Download
M content/common/url_constants.h View 1 2 3 4 2 chunks +21 lines, -19 lines 0 comments Download
M content/common/view_messages.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/view_types.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/webkit_param_traits.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/p2p/host_address_request.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/p2p/ipc_network_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/p2p/ipc_socket_factory.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.h View 3 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/render_process_observer.h View 1 chunk +2 lines, -1 line 1 comment Download
M content/renderer/render_thread.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/render_view.h View 1 2 6 chunks +25 lines, -21 lines 0 comments Download
M content/renderer/render_view_observer.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -2 lines 0 comments Download
M content/renderer/v8_value_converter.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/web_ui_bindings.h View 2 chunks +3 lines, -2 lines 0 comments Download
M content/utility/utility_thread.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M ui/base/dragdrop/download_file_interface.h View 1 2 3 4 5 6 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dirk Pranke
Darin, can you take a look at this? Generally speaking I exported entire classes, except ...
9 years, 3 months ago (2011-09-02 21:32:08 UTC) #1
darin (slow to review)
It was hard for me to evaluate whether exporting an entire class or individual methods ...
9 years, 3 months ago (2011-09-04 15:41:04 UTC) #2
Dirk Pranke
http://codereview.chromium.org/7800015/diff/5001/content/browser/appcache/chrome_appcache_service.h File content/browser/appcache/chrome_appcache_service.h (right): http://codereview.chromium.org/7800015/diff/5001/content/browser/appcache/chrome_appcache_service.h#newcode36 content/browser/appcache/chrome_appcache_service.h:36: NON_EXPORTED_BASE(public appcache::AppCacheService), On 2011/09/04 15:41:04, darin wrote: > the ...
9 years, 3 months ago (2011-09-07 01:46:06 UTC) #3
Dirk Pranke
John, can I get an approval for the files in content/utility? Will, can I get ...
9 years, 3 months ago (2011-09-13 18:47:22 UTC) #4
jam
utility lgtm http://codereview.chromium.org/7800015/diff/15002/content/renderer/render_process_observer.h File content/renderer/render_process_observer.h (right): http://codereview.chromium.org/7800015/diff/15002/content/renderer/render_process_observer.h#newcode11 content/renderer/render_process_observer.h:11: #include "content/common/content_export.h" nit: order
9 years, 3 months ago (2011-09-13 19:05:34 UTC) #5
willchan no longer on Chromium
9 years, 3 months ago (2011-09-13 19:18:21 UTC) #6 
content/browser/net lgtm

On 2011/09/13 19:05:34, John Abd-El-Malek wrote:
> utility lgtm
> 
>
http://codereview.chromium.org/7800015/diff/15002/content/renderer/render_pro...
> File content/renderer/render_process_observer.h (right):
> 
>
http://codereview.chromium.org/7800015/diff/15002/content/renderer/render_pro...
> content/renderer/render_process_observer.h:11: #include
> "content/common/content_export.h"
> nit: order

Powered by Google App Engine
This is Rietveld 408576698