Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 7800012: Add Android-specific platform guards to Chromium's LevelDB environment. (Closed)

Created:
9 years, 3 months ago by Peter Beverloo
Modified:
9 years, 3 months ago
CC:
chromium-reviews, gabor_google.com
Visibility:
Public.

Description

Add Android-specific platform guards to Chromium's LevelDB environment. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98878

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/leveldatabase/env_chromium.cc View 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dgrogan
This LGTM, but see if gabor has anything to add. He first ported leveldb to ...
9 years, 3 months ago (2011-08-30 17:24:31 UTC) #1
hans
On 2011/08/30 17:24:31, dgrogan wrote: > This LGTM, but see if gabor has anything to ...
9 years, 3 months ago (2011-08-30 17:29:41 UTC) #2
gabor_google.com
Is this for Clank? If so, this looks good, but don't forget to port the ...
9 years, 3 months ago (2011-08-30 18:03:25 UTC) #3
commit-bot: I haz the power
Try job failure for 7800012-1 on win for steps "update_scripts, update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=51914 Step "update" is ...
9 years, 3 months ago (2011-08-30 19:13:17 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-08-30 23:22:31 UTC) #5
Change committed as 98878

Powered by Google App Engine
This is Rietveld 408576698