Do not count image search results towards the GWS metric.

Do not count image search results towards the GWS metric.
R=dominich@chromium.org, cbentzel@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98812

[tburkard, 2011-08-30 01:13:35]

whoops forgot an argument, fixed.

[cbentzel, 2011-08-30 13:37:56]

LGTM

[dominich, 2011-08-30 14:38:11]

http://codereview.chromium.org/7800010/diff/4001/chrome/browser/prerender/pre...
File chrome/browser/prerender/prerender_manager.cc (right):

http://codereview.chromium.org/7800010/diff/4001/chrome/browser/prerender/pre...
chrome/browser/prerender/prerender_manager.cc:303:
!StartsWithASCII(referrer.path(), std::string("/imgres"), true)) {
As other Google properties use prerendering we will need this to scale better.
Instead of a negative match on the path, can we do a positive match:

StartsWithASCII(referrer.path(), std::string("/search"), true);

[tburkard, 2011-08-30 14:41:24]

That doesn't work because with Instnat some searches will not have a search
prefix (I actually wanted to do it exactly like that first, but then Ziga
told me it wouldn't work).

Thanks.

Timo

On Tue, Aug 30, 2011 at 7:38 AM, <dominich@chromium.org> wrote:

>
> http://codereview.chromium.**org/7800010/diff/4001/chrome/**
>
browser/prerender/prerender_**manager.cc<http://codereview.chromium.org/7800010/diff/4001/chrome/browser/prerender/prerender_manager.cc>
> File chrome/browser/prerender/**prerender_manager.cc (right):
>
> http://codereview.chromium.**org/7800010/diff/4001/chrome/**
>
browser/prerender/prerender_**manager.cc#newcode303<http://codereview.chromium.org/7800010/diff/4001/chrome/browser/prerender/prerender_manager.cc#newcode303>
> chrome/browser/prerender/**prerender_manager.cc:303:
> !StartsWithASCII(referrer.**path(), std::string("/imgres"), true)) {
> As other Google properties use prerendering we will need this to scale
> better. Instead of a negative match on the path, can we do a positive
> match:
>
> StartsWithASCII(referrer.path(**), std::string("/search"), true);
>
>
>
http://codereview.chromium.**org/7800010/<http://codereview.chromium.org/7800...
>

[dominich, 2011-08-30 14:48:28]

LGTM

Can you check for /search or empty path?

What you have works, it's just not scalable.

[tburkard, 2011-08-30 14:50:25]

I committed this for now, but I will discuss with Ziga to see if there is a
better way to do it.  I agree, this does not scale.

Timo

On Tue, Aug 30, 2011 at 7:48 AM, <dominich@chromium.org> wrote:

> LGTM
>
> Can you check for /search or empty path?
>
> What you have works, it's just not scalable.
>
>
>
>
http://codereview.chromium.**org/7800010/<http://codereview.chromium.org/7800...
>