Issue 7800006: Call glFinish just before reallocating offscreen_saved_color_texture_

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7800006: Call glFinish just before reallocating offscreen_saved_color_texture_ (Closed)

Created:
9 years, 3 months ago by Ken Russell (switch to Gerrit)

Modified:
9 years, 3 months ago

Reviewers:
apatrick_chromium, piman

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Call glFinish just before reallocating offscreen_saved_color_texture_ as possible workaround for crash in NVIDIA driver on Mac. Also fixed bug ID in comment. BUG=94103 TEST=none (manually tested some WebGL content) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98729

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

Please review. Thanks. Note that the workaround I tried late last week was buggy and ...

9 years, 3 months ago (2011-08-29 22:55:13 UTC) #1

LGTM

Expand Messages | Collapse Messages