Issue 7800004: Move more files to content_unittests.

Issue 7800004: Move more files to content_unittests. (Closed)

Created:
9 years, 3 months ago by Paweł Hajdan Jr.

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, jam

CC:
chromium-reviews, Avi (use Gerrit), Paweł Hajdan Jr., jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move more files to content_unittests. Reduce dependencies on chrome/ BUG=90443 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98823

Patch Set 2 : remove useless test #

Patch Set 3 : fix build #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+242 lines, -71 lines)			Patch
M	chrome/chrome_tests.gypi	View	1 2	2 chunks	+0 lines, -12 lines	0 comments	Download
M	content/browser/DEPS	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/debugger/devtools_manager_unittest.cc	View		4 chunks	+33 lines, -9 lines	0 comments	Download
M	content/browser/mock_content_browser_client.cc	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/browser/plugin_service_unittest.cc	View	1	1 chunk	+0 lines, -43 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents_view.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	content/content_tests.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
A	content/test/test_tab_contents_view.h	View	1 2	1 chunk	+74 lines, -0 lines	0 comments	Download
A	content/test/test_tab_contents_view.cc	View	1 2	1 chunk	+131 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm http://codereview.chromium.org/7800004/diff/1/content/browser/plugin_service_unittest.cc File content/browser/plugin_service_unittest.cc (right): http://codereview.chromium.org/7800004/diff/1/content/browser/plugin_service_unittest.cc#newcode28 content/browser/plugin_service_unittest.cc:28: ASSERT_TRUE(PluginService::GetInstance()); (not related to your change) this test ...

9 years, 3 months ago (2011-08-29 22:06:56 UTC) #2

Paweł Hajdan Jr.

http://codereview.chromium.org/7800004/diff/1/content/browser/plugin_service_unittest.cc File content/browser/plugin_service_unittest.cc (right): http://codereview.chromium.org/7800004/diff/1/content/browser/plugin_service_unittest.cc#newcode28 content/browser/plugin_service_unittest.cc:28: ASSERT_TRUE(PluginService::GetInstance()); On 2011/08/29 22:06:56, John Abd-El-Malek wrote: > (not ...

9 years, 3 months ago (2011-08-29 22:12:13 UTC) #3

commit-bot: I haz the power

9 years, 3 months ago (2011-08-30 00:56:44 UTC) #4

Can't apply patch for file content/browser/plugin_service_unittest.cc.
While running svn propset svn:eol-style LF
content/browser/plugin_service_unittest.cc --config-dir
/mnt/data/b/commit-queue/subversion_config --non-interactive;
patching file content/browser/plugin_service_unittest.cc
svn: Can't open file 'content/browser/plugin_service_unittest.cc': No such file
or directory

Expand Messages | Collapse Messages