Issue 7799034: Call prepareSort before any sorting happens.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7799034: Call prepareSort before any sorting happens. (Closed)

Created:
9 years, 3 months ago by rginda

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Call prepareSort before any sorting happens. The file manager code depends on the prepareSort method to fetch required sort fields from the filesystem before a sort happens, but the ArrayDataModel doesn't always call it. This makes for unsorted file lists in certain situations. BUG=chromium-os:19834 TEST=manual testing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98901

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -15 lines)			Patch
	M	chrome/browser/resources/shared/js/cr/ui/array_data_model.js	View		2 chunks	+22 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rginda

AFAICT the trybot failures are flaky tests, and not a problem with this CL.

9 years, 3 months ago (2011-08-30 21:44:46 UTC) #1

Change committed as 98901

Expand Messages | Collapse Messages