Lock the prototype of internal classes.

Lock the prototype of internal classes.

Prototypes and their properties and methods are locked down to prevent fiddling with their operation, even if the build-in object leaks.

Made some built-in functions only work during bootstrapping.

Committed: http://code.google.com/p/v8/source/detail?r=9122

[Erik Corry, 2011-08-31 05:46:04]

LGTM with a debug mode Sputnik run and benchmark results.

http://codereview.chromium.org/7799027/diff/1/src/array.js
File src/array.js (right):

http://codereview.chromium.org/7799027/diff/1/src/array.js#newcode1319
src/array.js:1319: // Setup non-enumerable constructor property on the
Array.prototype
While we are here:  "Set up", the verb, is two words.  "Setup", the noun, is one
word.  This is several places in the comments and also SetupArray -> SetUpArray.

http://codereview.chromium.org/7799027/diff/1/src/date.js
File src/date.js (right):

http://codereview.chromium.org/7799027/diff/1/src/date.js#newcode1051
src/date.js:1051: function SetupDate() {
SetupDate -> SetUpDate

http://codereview.chromium.org/7799027/diff/1/src/json.js
File src/json.js (right):

http://codereview.chromium.org/7799027/diff/1/src/json.js#newcode340
src/json.js:340: function SetupJSON() {
SetUpJSON

http://codereview.chromium.org/7799027/diff/1/src/math.js
File src/math.js (right):

http://codereview.chromium.org/7799027/diff/1/src/math.js#newcode198
src/math.js:198: function SetupMath() {
SetUpMath

http://codereview.chromium.org/7799027/diff/1/src/regexp.js
File src/regexp.js (right):

http://codereview.chromium.org/7799027/diff/1/src/regexp.js#newcode408
src/regexp.js:408: function SetupRegExp() {
SetUpRegExp

http://codereview.chromium.org/7799027/diff/1/src/runtime.h
File src/runtime.h (right):

http://codereview.chromium.org/7799027/diff/1/src/runtime.h#newcode81
src/runtime.h:81: /* Utilities */ \
We try to use 'assert' for things that only work in debug mode and 'check' for
things that work always.

http://codereview.chromium.org/7799027/diff/1/src/string.js
File src/string.js (right):

http://codereview.chromium.org/7799027/diff/1/src/string.js#newcode942
src/string.js:942: function SetupString() {
SetUpString

http://codereview.chromium.org/7799027/diff/1/src/uri.js
File src/uri.js (right):

http://codereview.chromium.org/7799027/diff/1/src/uri.js#newcode396
src/uri.js:396: %AssertIsBootstrapping();
SetUpURI

http://codereview.chromium.org/7799027/diff/1/src/v8natives.js
File src/v8natives.js (right):

http://codereview.chromium.org/7799027/diff/1/src/v8natives.js#newcode188
src/v8natives.js:188: function SetupGlobal() {
SetUpGlobal

http://codereview.chromium.org/7799027/diff/1/src/v8natives.js#newcode507
src/v8natives.js:507: SetupLockedPrototype(PropertyDescriptor, $Array(
SetUpLockedPrototype

http://codereview.chromium.org/7799027/diff/1/src/v8natives.js#newcode1173
src/v8natives.js:1173: function SetupObject() {
SetUpObject

http://codereview.chromium.org/7799027/diff/1/src/v8natives.js#newcode1237
src/v8natives.js:1237: function SetupBoolean() {
SetUpBoolean

http://codereview.chromium.org/7799027/diff/1/src/v8natives.js#newcode1360
src/v8natives.js:1360: %AssertIsBootstrapping();
SetUpNumber

http://codereview.chromium.org/7799027/diff/1/src/v8natives.js#newcode1532
src/v8natives.js:1532: %AssertIsBootstrapping();
SetUpFunction

http://codereview.chromium.org/7799027/diff/1/src/weakmap.js
File src/weakmap.js (right):

http://codereview.chromium.org/7799027/diff/1/src/weakmap.js#newcode83
src/weakmap.js:83: function SetupWeakMap() {
SetUpWeakMap

[Lasse Reichstein, 2011-09-01 13:30:42]

http://codereview.chromium.org/7799027/diff/1/src/array.js
File src/array.js (right):

http://codereview.chromium.org/7799027/diff/1/src/array.js#newcode1319
src/array.js:1319: // Setup non-enumerable constructor property on the
Array.prototype
Fixed in comments.

http://codereview.chromium.org/7799027/diff/1/src/array.js#newcode1374
src/array.js:1374: SetupLockedPrototype(InternalArray, $Array(), $Array(
Changed to SetUp....

http://codereview.chromium.org/7799027/diff/1/src/date.js
File src/date.js (right):

http://codereview.chromium.org/7799027/diff/1/src/date.js#newcode1051
src/date.js:1051: function SetupDate() {
I can do better - and make this a direct call of a function literal. 
I'm considering not making it a function at all.

http://codereview.chromium.org/7799027/diff/1/src/runtime.h
File src/runtime.h (right):

http://codereview.chromium.org/7799027/diff/1/src/runtime.h#newcode81
src/runtime.h:81: /* Utilities */ \
Changed to Check.