src/runtime.cc - Issue 7799026: Make proxies work as prototypes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 7799026: Make proxies work as prototypes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 5d6727a0a486ac794405deb13e42657c29d97a73..40e21d2c1100612735738a5043655dbce25b0aca 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -4491,7 +4491,9 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_HasProperty) {

if (args[0]->IsJSReceiver()) {

JSReceiver* receiver = JSReceiver::cast(args[0]);

CONVERT_CHECKED(String, key, args[1]);

- if (receiver->HasProperty(key)) return isolate->heap()->true_value();

+ bool result = receiver->HasProperty(key);

+ if (isolate->has_pending_exception()) return Failure::Exception();

+ if (result) return isolate->heap()->true_value();

Kevin Millikin (Chromium) 2011/08/31 10:15:31 You can also write this without the if as: return

rossberg 2011/08/31 13:28:32 Done.

}

return isolate->heap()->false_value();

}