Issue 7799015: ntp4: some appearance fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7799015: ntp4: some appearance fixes (Closed)

Created:
9 years, 3 months ago by Evan Stade

Modified:
9 years, 3 months ago

Reviewers:
csilv, Dan Beam (Google), Dan Beam

CC:
chromium-reviews, estade+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ntp4: some appearance fixes 1. make drag-over state match hover state for page switchers and nav dots 2. make recently closed text and arrow a hardcoded color (looks fine on a variety of themes; matches nav dot text) 3. don't show pulse for right click on apps BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98864

Patch Set 1 #

Patch Set 2 : . #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -27 lines)			Patch
M	chrome/browser/resources/ntp4/apps_page.css	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/resources/ntp4/apps_page.js	View	1	2 chunks	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp4/drag_wrapper.js	View		6 chunks	+7 lines, -9 lines	0 comments	Download
M	chrome/browser/resources/ntp4/nav_dot.css	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab.css	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/ntp4/new_tab_theme.css	View		2 chunks	+0 lines, -15 lines	0 comments	Download
M	chrome/browser/resources/ntp4/recently_closed.css	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dan Beam (Google)

LGTM (but I can't speak to the theme or dot stuff much with my current ...

9 years, 3 months ago (2011-08-30 02:21:42 UTC) #2

lgtm

Expand Messages | Collapse Messages