Issue 7799014: Fix stuck keys problem with Chromoting when host disconnects while keys are

Issue 7799014: Fix stuck keys problem with Chromoting when host disconnects while keys are (Closed)

Created:
9 years, 3 months ago by garykac

Modified:
9 years, 3 months ago

Reviewers:
Sergey Ulanov, Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix stuck keys problem with Chromoting when host disconnects while keys are down. BUG=84544 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98825

Patch Set 1 #

Patch Set 2 : use DeleteTask #

Total comments: 4

Patch Set 3 : review comments - add DCHECK #

Patch Set 4 : update copyright #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -9 lines)			Patch
	M	remoting/host/client_session.cc	View	1 2	5 chunks	+9 lines, -8 lines	0 comments	Download
	M	remoting/protocol/input_sender.cc	View	1 2 3	3 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

LGTM with two nits http://codereview.chromium.org/7799014/diff/1001/remoting/host/client_session.cc File remoting/host/client_session.cc (right): http://codereview.chromium.org/7799014/diff/1001/remoting/host/client_session.cc#newcode181 remoting/host/client_session.cc:181: KeyEvent* key = new protocol::KeyEvent(); ...

9 years, 3 months ago (2011-08-30 02:27:39 UTC) #2

garykac

9 years, 3 months ago (2011-08-30 16:31:48 UTC) #4

http://codereview.chromium.org/7799014/diff/1001/remoting/host/client_session.cc
File remoting/host/client_session.cc (right):

http://codereview.chromium.org/7799014/diff/1001/remoting/host/client_session...
remoting/host/client_session.cc:181: KeyEvent* key = new protocol::KeyEvent();
On 2011/08/30 02:27:39, sergeyu wrote:
> nit: s/protocol:://

Done.

http://codereview.chromium.org/7799014/diff/1001/remoting/host/client_session...
remoting/host/client_session.cc:184: input_stub_->InjectKeyEvent(key, new
DeleteTask<KeyEvent>(key));
On 2011/08/30 02:27:39, sergeyu wrote:
> Please add DCHECK(done_task) in InputSender::Inject*Event() to make sure we
> don't have similar bugs in the future.

Done.

Expand Messages | Collapse Messages