Intial Thumb2 Sandbox (naclrev 6680)

src/trusted/service_runtime/sel_validate_image.c

 /*
  * Copyright (c) 2011 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "native_client/src/shared/platform/nacl_log.h"
 #include "native_client/src/trusted/service_runtime/sel_ldr.h"
 #include "native_client/src/trusted/validator/ncvalidate.h"
 
@@ skipping 10 matching lines @@
     case NaClValidationFailedCpuNotSupported:
     case NaClValidationFailedSegmentationIssue:
     default:
       return LOAD_VALIDATION_FAILED;
   }
 }
 
 int NaClValidateCode(struct NaClApp *nap, uintptr_t guest_addr,
                      uint8_t *data, size_t size) {
   NaClValidationStatus status = NaClValidationSucceeded;
+#if NACL_ARCH(NACL_BUILD_ARCH) == NACL_arm

[Karl, 2011/08/30 19:53:52]

Again, I think this code is confusing build with target.

+    uintptr_t entry = nap->user_entry_pt ?
+                      nap->user_entry_pt : nap->initial_entry_pt;
+    uint8_t thumb = entry & 1;
+#endif
   if (nap->validator_stub_out_mode) {
     /* In stub out mode, we do two passes.  The second pass acts as a
        sanity check that bad instructions were indeed overwritten with
        allowable HLTs. */
     status = NACL_SUBARCH_NAME(ApplyValidator,
                                NACL_TARGET_ARCH,
                                NACL_TARGET_SUBARCH)(
                                    NaClApplyValidationDoStubout,
                                    guest_addr, data, size,
-                                   nap->bundle_size, TRUE);
+                                   nap->bundle_size, TRUE
+#if NACL_ARCH(NACL_BUILD_ARCH) == NACL_arm
+, thumb

[Karl, 2011/08/30 19:53:52]

Why is "thumb" needed. Isn't it already communicated with the
NACL_TARGET_SUBARCH?

[bsy, 2011/09/01 00:30:00]

stylistically speaking, conditionally adding an actual argument in this way is a
bit yucky.

[jasonwkim, 2011/09/16 20:09:16]

Fixex

+#endif
+);
   }
   if (status == NaClValidationSucceeded) {
     status = NACL_SUBARCH_NAME(ApplyValidator,
                                NACL_TARGET_ARCH,
                                NACL_TARGET_SUBARCH)(
                                    NaClApplyCodeValidation,
                                    guest_addr, data, size,
-                                   nap->bundle_size, TRUE);
+                                   nap->bundle_size, TRUE
+#if NACL_ARCH(NACL_BUILD_ARCH) == NACL_arm
+, thumb

[Karl, 2011/08/30 19:53:52]

Same question as above.

+#endif
+);
   }
   return NaClValidateStatus(status);
 }
 
 int NaClValidateCodeReplacement(struct NaClApp *nap, uintptr_t guest_addr,
                                 uint8_t *data_old, uint8_t *data_new,
                                 size_t size) {
+#if NACL_ARCH(NACL_BUILD_ARCH) == NACL_arm
+    uintptr_t entry = nap->user_entry_pt ?
+                      nap->user_entry_pt : nap->initial_entry_pt;
+    uint8_t thumb = entry & 1;
+#endif
   if (nap->validator_stub_out_mode) return LOAD_BAD_FILE;
 
   if ((guest_addr % nap->bundle_size) != 0 ||
       (size % nap->bundle_size) != 0) {
     return LOAD_BAD_FILE;
   }
-
   return NaClValidateStatus(
       NACL_SUBARCH_NAME(ApplyValidatorCodeReplacement,
                         NACL_TARGET_ARCH,
                         NACL_TARGET_SUBARCH)
-      (guest_addr, data_old, data_new, size, nap->bundle_size));
+      (guest_addr, data_old, data_new, size, nap->bundle_size
+#if NACL_ARCH(NACL_BUILD_ARCH) == NACL_arm
+, thumb
+#endif
+));
 }
 
 int NaClCopyCode(struct NaClApp *nap, uintptr_t guest_addr,
                  uint8_t *data_old, uint8_t *data_new,
                  size_t size) {
+#if NACL_ARCH(NACL_BUILD_ARCH) == NACL_arm
+    uintptr_t entry = nap->user_entry_pt ?
+                      nap->user_entry_pt : nap->initial_entry_pt;
+    uint8_t thumb = entry & 1;
+#endif
   return NaClValidateStatus(
       NACL_SUBARCH_NAME(ApplyValidatorCopy,
                         NACL_TARGET_ARCH,
                         NACL_TARGET_SUBARCH)
-      (guest_addr, data_old, data_new, size, nap->bundle_size));
+      (guest_addr, data_old, data_new, size, nap->bundle_size
+#if NACL_ARCH(NACL_BUILD_ARCH) == NACL_arm
+, thumb
+#endif
+));
 }
-
 NaClErrorCode NaClValidateImage(struct NaClApp  *nap) {
   uintptr_t               memp;
   uintptr_t               endp;
   size_t                  regionsize;
   NaClErrorCode           rcode;
 
   memp = nap->mem_start + NACL_TRAMPOLINE_END;
   endp = nap->mem_start + nap->static_text_end;
   regionsize = endp - memp;
   if (endp < memp) {
@@ skipping 15 matching lines @@
         NaClLog(LOG_ERROR,
                 "Run sel_ldr in debug mode to ignore validation failure.\n");
         NaClLog(LOG_ERROR,
                 "Run ncval <module-name> for validation error details.\n");
         rcode = LOAD_VALIDATION_FAILED;
       }
     }
   }
   return rcode;
 }