Intial Thumb2 Sandbox (naclrev 6680)

src/trusted/validator_arm/validator_tests.cc

 /*
  * Copyright 2010 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can
  * be found in the LICENSE file.
  */
 
 /*
  * Unit tests for the ARM validator
  *
  * These tests use the google-test framework (gtest for short) to exercise the
@@ skipping 173 matching lines @@
 
 TEST_F(ValidatorTests, GeneratesCorrectMasksFromSizes) {
   EXPECT_EQ(0xC0000000, _validator.data_address_mask());
   EXPECT_EQ(0xE000000F, _validator.code_address_mask());
 
   // Reinitialize the validator to test a different bundle size.
   _validator = SfiValidator(32,
                             kCodeRegionSize,
                             kDataRegionSize,
                             kAbiReadOnlyRegisters,
-                            kAbiDataAddrRegisters);
+                            kAbiDataAddrRegisters,
+                            0);  // ARM mode

[bsy, 2011/09/16 18:35:52]

comment like this is a good indication that an enum with symbolic names would be
nice.

   EXPECT_EQ(0xC0000000, _validator.data_address_mask())
       << "Changes in bundle size should not affect the data mask.";
   EXPECT_EQ(0xE000001F, _validator.code_address_mask())
       << "Changes in bundle size must affect the code mask.";
 }
 
 /*
  * Code validation tests
  */
 
@@ skipping 396 matching lines @@
 
 /*
  * Implementation of the ValidatorTests utility methods.  These are documented
  * toward the top of this file.
  */
 ValidatorTests::ValidatorTests()
   : _validator(kBytesPerBundle,
                kCodeRegionSize,
                kDataRegionSize,
                kAbiReadOnlyRegisters,
-               kAbiDataAddrRegisters) {}
+               kAbiDataAddrRegisters,
+               0) {}
 
 bool ValidatorTests::validate(const arm_inst *pattern,
                               size_t inst_count,
                               uint32_t start_addr,
                               ProblemSink *sink) {
   // We think in instructions; CodeSegment thinks in bytes.
   const uint8_t *bytes = reinterpret_cast<const uint8_t *>(pattern);
   CodeSegment segment(bytes, start_addr, inst_count * sizeof(arm_inst));
 
   vector<CodeSegment> segments;
@@ skipping 77 matching lines @@
   return problems;
 }
 
 };  // anonymous namespace
 
 // Test driver function.
 int main(int argc, char *argv[]) {
   testing::InitGoogleTest(&argc, argv);
   return RUN_ALL_TESTS();
 }