Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 7799009: Fix NOTIFICATION_RENDER_WIDGET_HOST_DESTROYED. (Closed)

Created:
9 years, 3 months ago by Avi (use Gerrit)
Modified:
9 years, 3 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Avi (use Gerrit), jam, brettw-cc_chromium.org
Visibility:
Public.

Description

Fix NOTIFICATION_RENDER_WIDGET_HOST_DESTROYED. For NOTIFICATION_RENDER_WIDGET_HOST_DESTROYED the source is a RenderWidgetHost, and there are no details. Fix all the places that do the wrong thing. BUG=94653 TEST=no DCHECK when closing a tab while a file picker is up Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98830

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/browser/file_select_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/popup_menu_helper_mac.mm View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/tab_contents/interstitial_page.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
9 years, 3 months ago (2011-08-29 22:09:57 UTC) #1
jam
9 years, 3 months ago (2011-08-30 16:50:36 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698