Fix crash on NTP related to multi-profile extensions.

Fix crash on NTP related to multi-profile extensions.

This makes sure the NTP only listens for extension related notifications from the current profile. It also updates some of the sources for extension notifications in the Browser and ExtensionManagementEventRouters.

BUG=94438, 87457, 94034
TEST=see bug report

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98836

[Evan Stade, 2011-08-29 22:32:15]

it seems there are changes here not related to the NTP per se? e.g. the browser
change. Can you update the CL description to mention/explain that?

LGTM

[Yoyo Zhou, 2011-08-29 22:40:46]

LGTM for the most part

You might also consider adding 94034 to the BUG=.

http://codereview.chromium.org/7799008/diff/1/chrome/browser/ui/webui/ntp/app...
File chrome/browser/ui/webui/ntp/app_launcher_handler.cc (right):

http://codereview.chromium.org/7799008/diff/1/chrome/browser/ui/webui/ntp/app...
chrome/browser/ui/webui/ntp/app_launcher_handler.cc:473: registrar_.Add(this,
chrome::NOTIFICATION_APP_NOTIFICATION_STATE_CHANGED,
This looks like it could possibly be sent from an incognito profile, in which
case we still need to listen to AllSources and filter by IsSameProfile.

[Miranda Callahan, 2011-08-30 08:12:30]

On 2011/08/29 22:40:46, Yoyo Zhou wrote:
> LGTM for the most part
> 
> You might also consider adding 94034 to the BUG=.
> 
>
http://codereview.chromium.org/7799008/diff/1/chrome/browser/ui/webui/ntp/app...
> File chrome/browser/ui/webui/ntp/app_launcher_handler.cc (right):
> 
>
http://codereview.chromium.org/7799008/diff/1/chrome/browser/ui/webui/ntp/app...
> chrome/browser/ui/webui/ntp/app_launcher_handler.cc:473: registrar_.Add(this,
> chrome::NOTIFICATION_APP_NOTIFICATION_STATE_CHANGED,
> This looks like it could possibly be sent from an incognito profile, in which
> case we still need to listen to AllSources and filter by IsSameProfile.

LGTM w/Yoyo's suggestion.

[jstritar, 2011-08-30 15:06:31]

Updated the description and BUG= line based on your feedback.

Thanks for catching the incognito profile issue Yoyo... I forgot we need to
filter those manually. I also updated the
NOTIFICATION_EXTENSION_PROCESS_TERMINATED listener in Browser to filter based on
IsSameProfile. The other notifications are produced by the ExtensionService and
ExtensionPrefs, which are only associated with the non-incognito profile.

http://codereview.chromium.org/7799008/diff/1/chrome/browser/ui/webui/ntp/app...
File chrome/browser/ui/webui/ntp/app_launcher_handler.cc (right):

http://codereview.chromium.org/7799008/diff/1/chrome/browser/ui/webui/ntp/app...
chrome/browser/ui/webui/ntp/app_launcher_handler.cc:473: registrar_.Add(this,
chrome::NOTIFICATION_APP_NOTIFICATION_STATE_CHANGED,
On 2011/08/29 22:40:46, Yoyo Zhou wrote:
> This looks like it could possibly be sent from an incognito profile, in which
> case we still need to listen to AllSources and filter by IsSameProfile.

Done.

http://codereview.chromium.org/7799008/diff/4001/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/7799008/diff/4001/chrome/browser/ui/browser.cc...
chrome/browser/ui/browser.cc:3924: if (profile_->IsSameProfile(profile) &&
window()->GetLocationBar())
I think this can come from an incognito profile, so I'm filtering on
IsSameProfile to be safe.

[Yoyo Zhou, 2011-08-30 16:25:04]

LGTM again