Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 7799004: Make the "get window rect" message handlers report the work area, rather than the true window siz... (Closed)

Created:
9 years, 3 months ago by Peter Kasting
Modified:
9 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Make the "get window rect" message handlers report the work area, rather than the true window size, for maximized windows, since that's how the calling code expects them to function. BUG=88523 TEST=Open DevTools maximized (full single screen) on Windows Vista/7, click the Gearbox button in the Elements panel's Styles pane. The SELECT popup should not stick beyond the right screen edge and should be right-aligned with the right edge of the button. Move the Windows taskbar to the right edge of the screen and repeat. The popup should still get the correct alignment and should not get clipped in any way. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98881

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -15 lines) Patch
M content/browser/renderer_host/render_message_filter_win.cc View 2 chunks +33 lines, -15 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Peter Kasting
See if this fixes your bug. If so please feel free to edit the TEST= ...
9 years, 3 months ago (2011-08-29 18:52:01 UTC) #1
apavlov
On 2011/08/29 18:52:01, Peter Kasting wrote: > See if this fixes your bug. If so ...
9 years, 3 months ago (2011-08-30 11:15:03 UTC) #2
Peter Kasting
Ben, can you OWNERS r+?
9 years, 3 months ago (2011-08-30 20:03:29 UTC) #3
Ben Goodger (Google)
http://codereview.chromium.org/7799004/diff/1/content/browser/renderer_host/render_message_filter_win.cc File content/browser/renderer_host/render_message_filter_win.cc (right): http://codereview.chromium.org/7799004/diff/1/content/browser/renderer_host/render_message_filter_win.cc#newcode32 content/browser/renderer_host/render_message_filter_win.cc:32: GetSystemMetrics(SM_CYSIZEFRAME)); Are all Windows apps typically larger than the ...
9 years, 3 months ago (2011-08-30 20:06:24 UTC) #4
Peter Kasting
9 years, 3 months ago (2011-08-30 20:08:53 UTC) #5
Landing.

http://codereview.chromium.org/7799004/diff/1/content/browser/renderer_host/r...
File content/browser/renderer_host/render_message_filter_win.cc (right):

http://codereview.chromium.org/7799004/diff/1/content/browser/renderer_host/r...
content/browser/renderer_host/render_message_filter_win.cc:32:
GetSystemMetrics(SM_CYSIZEFRAME));
On 2011/08/30 20:06:24, Ben Goodger (Google) wrote:
> Are all Windows apps typically larger than the work area when maximized?

As far as I know, yes.  I double-checked with Wordpad and it behaves this same
way.

Powered by Google App Engine
This is Rietveld 408576698