Issue 7799003: Add printing.dll to the component build.

Issue 7799003: Add printing.dll to the component build. (Closed)

Created:
9 years, 3 months ago by darin (slow to review)

Modified:
9 years, 3 months ago

Reviewers:
Lei Zhang, rvargas (doing something else)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add printing.dll to the component build. R=rvargas,thestig Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99144

Patch Set 10 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -84 lines)			Patch
M	printing/backend/cups_helper.h	View	1 2 3 4 5 6 7 8 9	2 chunks	+3 lines, -1 line	0 comments	Download
M	printing/backend/print_backend.h	View	1 2 3 4 5 6 7 8 9	4 chunks	+5 lines, -3 lines	0 comments	Download
M	printing/backend/print_backend_consts.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+8 lines, -6 lines	0 comments	Download
M	printing/backend/win_helper.h	View	1 2 3 4 5 6 7 8 9	4 chunks	+4 lines, -3 lines	0 comments	Download
M	printing/emf_win.h	View	1 2 3 4 5 6 7 8 9	3 chunks	+3 lines, -3 lines	0 comments	Download
M	printing/image.h	View	1 2 3 4 5 6 7 8 9	2 chunks	+2 lines, -1 line	0 comments	Download
M	printing/metafile.h	View	1 2 3 4 5 6 7 8 9	2 chunks	+2 lines, -1 line	0 comments	Download
M	printing/metafile_skia_wrapper.h	View	1 2 3 4 5 6 7 8 9	2 chunks	+2 lines, -1 line	0 comments	Download
M	printing/page_number.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/page_range.h	View	1 2 3 4 5 6 7 8 9	2 chunks	+3 lines, -1 line	0 comments	Download
M	printing/page_setup.h	View	1 2 3 4 5 6 7 8 9	2 chunks	+3 lines, -2 lines	0 comments	Download
M	printing/pdf_metafile_cairo_linux.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/pdf_metafile_cg_mac.h	View	1 2 3 4 5 6 7 8 9	2 chunks	+3 lines, -1 line	0 comments	Download
M	printing/pdf_metafile_cg_mac.cc	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/pdf_metafile_skia.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/print_job_constants.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+38 lines, -36 lines	0 comments	Download
M	printing/print_settings.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/print_settings_initializer.h	View	1 2 3 4 5 6 7 8 9	2 chunks	+2 lines, -1 line	0 comments	Download
M	printing/print_settings_initializer_gtk.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/print_settings_initializer_mac.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/print_settings_initializer_win.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/printed_document.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+2 lines, -1 line	0 comments	Download
M	printing/printed_page.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+2 lines, -1 line	0 comments	Download
M	printing/printing.gyp	View	1 2 3 4 5 6 7 8 9	3 chunks	+6 lines, -2 lines	0 comments	Download
M	printing/printing_context.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/printing_context_cairo.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/printing_context_mac.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/printing_context_win.h	View	1 2 3 4 5 6 7 8 9	2 chunks	+2 lines, -2 lines	0 comments	Download
A	printing/printing_export.h	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	printing/units.h	View	1 2 3 4 5 6 7 8 9	2 chunks	+10 lines, -7 lines	0 comments	Download
M	webkit/appcache/webkit_appcache.gypi	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

This CL depends on the WebKit.gyp patch here: https://bugs.webkit.org/show_bug.cgi?id=67169

9 years, 3 months ago (2011-08-30 00:04:08 UTC) #1

rvargas (doing something else)

http://codereview.chromium.org/7799003/diff/39/printing/printing.gyp File printing/printing.gyp (right): http://codereview.chromium.org/7799003/diff/39/printing/printing.gyp#newcode12 printing/printing.gyp:12: 'type': '<(component)', I just realized that PRINTING_IMPLEMENTATION is missing.

9 years, 3 months ago (2011-08-30 19:40:24 UTC) #3

darin (slow to review)

So it is... I was only doing my local build and testing on Linux :-) ...

9 years, 3 months ago (2011-08-30 19:47:26 UTC) #4

LGTM

Expand Messages | Collapse Messages