Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: Source/WebCore/rendering/RenderTextControl.cpp

Issue 7797001: Merge 93802 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/835/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/forms/textarea-placeholder-relayout-assertion-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/rendering/RenderTextControl.cpp
===================================================================
--- Source/WebCore/rendering/RenderTextControl.cpp (revision 93984)
+++ Source/WebCore/rendering/RenderTextControl.cpp (working copy)
@@ -430,8 +430,12 @@
RenderObject* placeholderRenderer = placeholder ? placeholder->renderer() : 0;
if (!placeholderRenderer)
return 0;
- if (relayoutChildren)
- placeholderRenderer->setNeedsLayout(true);
+ if (relayoutChildren) {
+ // The markParents arguments should be false because this function is
+ // called from layout() of the parent and the placeholder layout doesn't
+ // affect the parent layout.
+ placeholderRenderer->setChildNeedsLayout(true, false);
+ }
return placeholderRenderer;
}
« no previous file with comments | « LayoutTests/fast/forms/textarea-placeholder-relayout-assertion-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698